a9da9ffc04Replace the domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes the REPL's dependency on the deprecated domain module while preserving all existing behavior: - Synchronous errors during eval are caught and displayed - Async errors (setTimeout, promises, etc.) are caught via the uncaught exception capture callback - Top-level await errors are caught and displayed - The REPL continues operating after errors - Multiple REPL instances can coexist with errors routed correctly Changes: - Use AsyncLocalStorage to track which REPL instance owns an async context, replacing domain's automatic async tracking - Add setupExceptionCapture() to install setUncaughtExceptionCaptureCallback for catching async errors and routing them to the correct REPL - Extract error handling logic into REPLServer.prototype._handleError() - Wrap eval execution in replContext.run() for async context tracking - Update newListener protection to check AsyncLocalStorage context - Throw ERR_INVALID_ARG_VALUE if options.domain is passed PR-URL: https://github.com/nodejs/node/pull/61227 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
70 lines
1.9 KiB
JavaScript
70 lines
1.9 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const { startNewREPLServer } = require('../common/repl');
|
|
|
|
let count = 0;
|
|
|
|
function run({ command, expected, useColors = false }) {
|
|
const { replServer, output } = startNewREPLServer({
|
|
prompt: '',
|
|
terminal: false,
|
|
useColors,
|
|
});
|
|
|
|
replServer.write(`${command}\n`);
|
|
|
|
if (typeof expected === 'string') {
|
|
assert.strictEqual(output.accumulator, expected);
|
|
} else {
|
|
assert.match(output.accumulator, expected);
|
|
}
|
|
|
|
// Verify that the repl is still working as expected.
|
|
output.accumulator = '';
|
|
replServer.write('1 + 1\n');
|
|
// eslint-disable-next-line no-control-regex
|
|
assert.strictEqual(output.accumulator.replace(/\u001b\[[0-9]+m/g, ''), '2\n');
|
|
replServer.close();
|
|
count++;
|
|
}
|
|
|
|
const tests = [
|
|
{
|
|
useColors: true,
|
|
command: 'x',
|
|
expected: 'Uncaught ReferenceError: x is not defined\n'
|
|
},
|
|
{
|
|
useColors: true,
|
|
command: 'throw { foo: "test" }',
|
|
expected: "Uncaught { foo: \x1B[32m'test'\x1B[39m }\n"
|
|
},
|
|
{
|
|
command: 'process.on("uncaughtException", () => console.log("Foobar"));\n',
|
|
expected: /^Uncaught:\nTypeError \[ERR_INVALID_REPL_INPUT]: Listeners for `/
|
|
},
|
|
{
|
|
command: 'x;\n',
|
|
expected: 'Uncaught ReferenceError: x is not defined\n'
|
|
},
|
|
{
|
|
command: 'process.on("uncaughtException", () => console.log("Foobar"));' +
|
|
'console.log("Baz");\n',
|
|
expected: /^Uncaught:\nTypeError \[ERR_INVALID_REPL_INPUT]: Listeners for `/
|
|
},
|
|
{
|
|
command: 'console.log("Baz");' +
|
|
'process.on("uncaughtException", () => console.log("Foobar"));\n',
|
|
expected: /^Baz\nUncaught:\nTypeError \[ERR_INVALID_REPL_INPUT]:.*uncaughtException/
|
|
},
|
|
];
|
|
|
|
process.on('exit', () => {
|
|
// To actually verify that the test passed we have to make sure no
|
|
// `uncaughtException` listeners exist anymore.
|
|
process.removeAllListeners('uncaughtException');
|
|
assert.strictEqual(count, tests.length);
|
|
});
|
|
|
|
tests.forEach(run);
|