node/test
Trivikram Kamat 75aec8ecf8
process: fix finalization cleanup ref tracking
Use SafeSet collections for finalization refs so insertion, removal,
and emptiness checks match the identity-based tracking model.

This also fixes cleanup removal for collected refs. Previously cleanup
used the ref index as the splice delete count, which could remove later
live refs when the collected ref was not first.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
PR-URL: https://github.com/nodejs/node/pull/64087
Fixes: https://github.com/nodejs/node/issues/64086
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
2026-06-30 21:38:02 +00:00
..
abort
addons domain: port to AsyncLocalStorage 2026-06-21 19:42:03 +00:00
async-hooks
benchmark
cctest src: abstract tracing agent for both legacy and perfetto 2026-06-29 13:57:02 +00:00
client-proxy test: fix typo from overriden to overridden 2026-06-24 21:20:19 +00:00
common test: improve lcov reporter snapshot diagnostics 2026-06-29 07:04:35 +00:00
doctool Revert "build, doc: generate node.1 with doc-kit" 2026-06-23 17:10:12 +00:00
embedding test: fix typo from funciton to function 2026-06-24 21:20:17 +00:00
es-module esm: add --experimental-import-text flag 2026-06-26 13:50:21 +00:00
ffi
fixtures process: fix finalization cleanup ref tracking 2026-06-30 21:38:02 +00:00
fuzzers src: abstract tracing agent for both legacy and perfetto 2026-06-29 13:57:02 +00:00
internet
js-native-api
known_issues
message
module-hooks
node-api domain: port to AsyncLocalStorage 2026-06-21 19:42:03 +00:00
nop
overlapped-checker
parallel process: fix finalization cleanup ref tracking 2026-06-30 21:38:02 +00:00
pseudo-tty
pummel
report
sea
sequential dgram: skip dns.lookup() for literal IP addresses 2026-06-30 13:07:49 +00:00
sqlite
system-ca
test-runner
test426
testpy
tick-processor
tools
v8-updates
wasi
wasm-allocation
wpt test: mark hr-time WPT flaky on macos15-x64 2026-06-24 05:09:17 +00:00
eslint.config_partial.mjs
README.md
root.status

Node.js Core Tests

This directory contains code and data used to test the Node.js implementation.

For a detailed guide on how to write tests in this directory, see the guide on writing tests.

On how to run tests in this directory, see the contributing guide.

For the tests to run on Windows, be sure to clone Node.js source code with the autocrlf git config flag set to true.

Test Directories

Directory Runs on CI Purpose
abort Yes Tests that use --abort-on-uncaught-exception and other cases where we want to avoid generating a core file.
addons Yes Tests for addon functionality along with some tests that require an addon.
async-hooks Yes Tests for async_hooks functionality.
benchmark Yes Test minimal functionality of benchmarks.
cctest Yes C++ tests that are run as part of the build process.
code-cache No Tests for a Node.js binary compiled with V8 code cache.
common N/A Common modules shared among many tests.1
doctool Yes Tests for the documentation generator.
es-module Yes Test ESM module loading.
fixtures N/A Test fixtures used in various tests throughout the test suite.
internet No Tests that make real outbound network connections.2
js-native-api Yes Tests for Node.js-agnostic Node-API functionality.
known_issues Yes Tests reproducing known issues within the system.3
message Yes Tests for messages that are output for various conditions
node-api Yes Tests for Node.js-specific Node-API functionality.
parallel Yes Various tests that are able to be run in parallel.
pseudo-tty Yes Tests that require stdin/stdout/stderr to be a TTY.
pummel No Various tests for various modules / system functionality operating under load.
sequential Yes Various tests that must not run in parallel.
testpy N/A Test configuration utility used by various test suites.
tick-processor No Tests for the V8 tick processor integration.4
v8-updates No Tests for V8 performance integration.

  1. Documentation ↩︎

  2. Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections. ↩︎

  3. All tests inside of this directory are expected to fail. If a test doesn't fail on certain platforms, those should be skipped via known_issues.status. ↩︎

  4. The tests are for the logic in lib/internal/main/prof_process.js and lib/internal/v8_prof_polyfill.js. The tests confirm that the profile processor packages the correct set of scripts from V8 and introduces the correct platform specific logic. ↩︎