Replace the domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes the REPL's dependency on the deprecated domain module while preserving all existing behavior: - Synchronous errors during eval are caught and displayed - Async errors (setTimeout, promises, etc.) are caught via the uncaught exception capture callback - Top-level await errors are caught and displayed - The REPL continues operating after errors - Multiple REPL instances can coexist with errors routed correctly Changes: - Use AsyncLocalStorage to track which REPL instance owns an async context, replacing domain's automatic async tracking - Add setupExceptionCapture() to install setUncaughtExceptionCaptureCallback for catching async errors and routing them to the correct REPL - Extract error handling logic into REPLServer.prototype._handleError() - Wrap eval execution in replContext.run() for async context tracking - Update newListener protection to check AsyncLocalStorage context - Throw ERR_INVALID_ARG_VALUE if options.domain is passed PR-URL: https://github.com/nodejs/node/pull/61227 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
22 lines
633 B
JavaScript
22 lines
633 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { startNewREPLServer } = require('../common/repl');
|
|
|
|
const { replServer, output } = startNewREPLServer({
|
|
prompt: '',
|
|
terminal: false,
|
|
useColors: false,
|
|
global: false,
|
|
eval: common.mustCall((code, context, filename, cb) => {
|
|
replServer.setPrompt('prompt! ');
|
|
cb(new Error('err'));
|
|
})
|
|
});
|
|
|
|
replServer.write('foo\n');
|
|
|
|
// The output includes exactly one post-error prompt.
|
|
assert.match(output.accumulator, /prompt!/);
|
|
assert.doesNotMatch(output.accumulator, /prompt![\S\s]*prompt!/);
|
|
output.on('data', common.mustNotCall());
|