a9da9ffc04Replace the domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes the REPL's dependency on the deprecated domain module while preserving all existing behavior: - Synchronous errors during eval are caught and displayed - Async errors (setTimeout, promises, etc.) are caught via the uncaught exception capture callback - Top-level await errors are caught and displayed - The REPL continues operating after errors - Multiple REPL instances can coexist with errors routed correctly Changes: - Use AsyncLocalStorage to track which REPL instance owns an async context, replacing domain's automatic async tracking - Add setupExceptionCapture() to install setUncaughtExceptionCaptureCallback for catching async errors and routing them to the correct REPL - Extract error handling logic into REPLServer.prototype._handleError() - Wrap eval execution in replContext.run() for async context tracking - Update newListener protection to check AsyncLocalStorage context - Throw ERR_INVALID_ARG_VALUE if options.domain is passed PR-URL: https://github.com/nodejs/node/pull/61227 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
57 lines
1.5 KiB
JavaScript
57 lines
1.5 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const repl = require('repl');
|
|
const { startNewREPLServer } = require('../common/repl');
|
|
|
|
if (process.env.TERM === 'dumb') {
|
|
common.skip('skipping - dumb terminal');
|
|
}
|
|
|
|
const tests = [
|
|
testSloppyMode,
|
|
testStrictMode,
|
|
testStrictModeTerminal,
|
|
];
|
|
|
|
tests.forEach(function(test) {
|
|
test();
|
|
});
|
|
|
|
function testSloppyMode() {
|
|
const { input, output } = startNewREPLServer({ replMode: repl.REPL_MODE_SLOPPY, terminal: false, prompt: '> ' });
|
|
|
|
input.emit('data', 'x = 3\n');
|
|
assert.strictEqual(output.accumulator, '> 3\n> ');
|
|
output.accumulator = '';
|
|
|
|
input.emit('data', 'let y = 3\n');
|
|
assert.strictEqual(output.accumulator, 'undefined\n> ');
|
|
}
|
|
|
|
function testStrictMode() {
|
|
const { input, output } = startNewREPLServer({
|
|
replMode: repl.REPL_MODE_STRICT, terminal: false, prompt: '> '
|
|
});
|
|
|
|
input.emit('data', 'x = 3\n');
|
|
assert.match(output.accumulator, /ReferenceError: x is not defined/);
|
|
output.accumulator = '';
|
|
|
|
input.emit('data', 'let y = 3\n');
|
|
assert.strictEqual(output.accumulator, 'undefined\n> ');
|
|
}
|
|
|
|
function testStrictModeTerminal() {
|
|
if (!process.features.inspector) {
|
|
console.warn('Test skipped: V8 inspector is disabled');
|
|
return;
|
|
}
|
|
// Verify that ReferenceErrors are reported in strict mode previews.
|
|
const { input, output } = startNewREPLServer({ replMode: repl.REPL_MODE_STRICT, prompt: '> ' });
|
|
|
|
input.emit('data', 'xyz ');
|
|
assert.ok(
|
|
output.accumulator.includes('\n// ReferenceError: xyz is not defined')
|
|
);
|
|
}
|