a9da9ffc04Replace the domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes the REPL's dependency on the deprecated domain module while preserving all existing behavior: - Synchronous errors during eval are caught and displayed - Async errors (setTimeout, promises, etc.) are caught via the uncaught exception capture callback - Top-level await errors are caught and displayed - The REPL continues operating after errors - Multiple REPL instances can coexist with errors routed correctly Changes: - Use AsyncLocalStorage to track which REPL instance owns an async context, replacing domain's automatic async tracking - Add setupExceptionCapture() to install setUncaughtExceptionCaptureCallback for catching async errors and routing them to the correct REPL - Extract error handling logic into REPLServer.prototype._handleError() - Wrap eval execution in replContext.run() for async context tracking - Update newListener protection to check AsyncLocalStorage context - Throw ERR_INVALID_ARG_VALUE if options.domain is passed PR-URL: https://github.com/nodejs/node/pull/61227 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
35 lines
1 KiB
JavaScript
35 lines
1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { startNewREPLServer } = require('../common/repl');
|
|
const assert = require('node:assert');
|
|
|
|
// This test checks that an eval function returning an error in its callback
|
|
// after the repl server has been closed doesn't cause an ERR_USE_AFTER_CLOSE
|
|
// error to be thrown (reference: https://github.com/nodejs/node/issues/58784)
|
|
|
|
(async () => {
|
|
const close$ = Promise.withResolvers();
|
|
const eval$ = Promise.withResolvers();
|
|
|
|
const { replServer, output } = startNewREPLServer({
|
|
eval(_cmd, _context, _file, cb) {
|
|
// eslint-disable-next-line node-core/must-call-assert
|
|
close$.promise.then(() => {
|
|
cb(new Error('Error returned from the eval callback'));
|
|
eval$.resolve();
|
|
});
|
|
},
|
|
});
|
|
|
|
replServer.write('\n');
|
|
|
|
replServer.close();
|
|
close$.resolve();
|
|
|
|
process.on('uncaughtException', common.mustNotCall());
|
|
|
|
await eval$.promise;
|
|
|
|
assert.match(output.accumulator, /Uncaught Error: Error returned from the eval callback/);
|
|
})().then(common.mustCall());
|