a9da9ffc04Replace the domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes the REPL's dependency on the deprecated domain module while preserving all existing behavior: - Synchronous errors during eval are caught and displayed - Async errors (setTimeout, promises, etc.) are caught via the uncaught exception capture callback - Top-level await errors are caught and displayed - The REPL continues operating after errors - Multiple REPL instances can coexist with errors routed correctly Changes: - Use AsyncLocalStorage to track which REPL instance owns an async context, replacing domain's automatic async tracking - Add setupExceptionCapture() to install setUncaughtExceptionCaptureCallback for catching async errors and routing them to the correct REPL - Extract error handling logic into REPLServer.prototype._handleError() - Wrap eval execution in replContext.run() for async context tracking - Update newListener protection to check AsyncLocalStorage context - Throw ERR_INVALID_ARG_VALUE if options.domain is passed PR-URL: https://github.com/nodejs/node/pull/61227 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
23 lines
763 B
JavaScript
23 lines
763 B
JavaScript
'use strict';
|
|
// Tests that setUncaughtExceptionCaptureCallback can be called after domain
|
|
// is loaded. This verifies that the mutual exclusivity has been removed.
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
// Load domain first
|
|
const domain = require('domain');
|
|
assert.ok(domain);
|
|
|
|
// Setting callback should not throw (coexistence is now supported)
|
|
process.setUncaughtExceptionCaptureCallback(common.mustNotCall());
|
|
|
|
// Verify callback is registered
|
|
assert.ok(process.hasUncaughtExceptionCaptureCallback());
|
|
|
|
// Clean up
|
|
process.setUncaughtExceptionCaptureCallback(null);
|
|
assert.ok(!process.hasUncaughtExceptionCaptureCallback());
|
|
|
|
// Domain should still be usable after callback operations
|
|
const d = domain.create();
|
|
assert.ok(d);
|