9e0dc8b472- copyBytesFrom: calculate byte offsets directly instead of
slicing into an intermediate typed array
- toString('hex'): use V8 Uint8Array.prototype.toHex() builtin
- fill: add single-char ASCII fast path
- indexOf: use indexOfString directly for ASCII encoding
- swap16/32/64: add V8 Fast API functions
PR-URL: https://github.com/nodejs/node/pull/61871
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
140 lines
6.2 KiB
JavaScript
140 lines
6.2 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const rangeBuffer = Buffer.from('abc');
|
|
|
|
// If start >= buffer's length, empty string will be returned
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 3), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', +Infinity), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 3.14, 3), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 'Infinity', 3), '');
|
|
|
|
// If end <= 0, empty string will be returned
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 1, 0), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 1, -1.2), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 1, -100), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 1, -Infinity), '');
|
|
|
|
// If start < 0, start will be taken as zero
|
|
assert.strictEqual(rangeBuffer.toString('ascii', -1, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', -1.99, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', -Infinity, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-1', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-1.99', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-Infinity', 3), 'abc');
|
|
|
|
// If start is an invalid integer, start will be taken as zero
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 'node.js', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', {}, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', [], 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', NaN, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', null, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', undefined, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', false, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '', 3), 'abc');
|
|
|
|
// But, if start is an integer when coerced, then it will be coerced and used.
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-1', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '1', 3), 'bc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-Infinity', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '3', 3), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', Number(3), 3), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '3.14', 3), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '1.99', 3), 'bc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-1.99', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 1.99, 3), 'bc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', true, 3), 'bc');
|
|
|
|
// If end > buffer's length, end will be taken as buffer's length
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, 5), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, 6.99), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, Infinity), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '5'), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '6.99'), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, 'Infinity'), 'abc');
|
|
|
|
// If end is an invalid integer, end will be taken as buffer's length
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, 'node.js'), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, {}), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, NaN), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, undefined), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, null), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, []), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, false), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, ''), '');
|
|
|
|
// But, if end is an integer when coerced, then it will be coerced and used.
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '-1'), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '1'), 'a');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '-Infinity'), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '3'), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, Number(3)), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '3.14'), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '1.99'), 'a');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '-1.99'), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, 1.99), 'a');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, true), 'a');
|
|
|
|
// Test hex/base64/base64url partial range encoding (exercises V8 builtin path)
|
|
{
|
|
const buf = Buffer.from([0xde, 0xad, 0xbe, 0xef, 0xca, 0xfe]);
|
|
assert.strictEqual(buf.toString('hex'), 'deadbeefcafe');
|
|
assert.strictEqual(buf.toString('hex', 0, 3), 'deadbe');
|
|
assert.strictEqual(buf.toString('hex', 2, 5), 'beefca');
|
|
assert.strictEqual(buf.toString('hex', 4), 'cafe');
|
|
assert.strictEqual(buf.toString('hex', 6), '');
|
|
assert.strictEqual(buf.toString('hex', 0, 0), '');
|
|
}
|
|
|
|
{
|
|
const buf = Buffer.from('Hello, World!');
|
|
assert.strictEqual(buf.toString('base64'), 'SGVsbG8sIFdvcmxkIQ==');
|
|
assert.strictEqual(buf.toString('base64', 0, 5), 'SGVsbG8=');
|
|
assert.strictEqual(buf.toString('base64', 7), 'V29ybGQh');
|
|
assert.strictEqual(buf.toString('base64', 0, 0), '');
|
|
}
|
|
|
|
{
|
|
const buf = Buffer.from('Hello, World!');
|
|
assert.strictEqual(buf.toString('base64url'), 'SGVsbG8sIFdvcmxkIQ');
|
|
assert.strictEqual(buf.toString('base64url', 0, 5), 'SGVsbG8');
|
|
assert.strictEqual(buf.toString('base64url', 7), 'V29ybGQh');
|
|
assert.strictEqual(buf.toString('base64url', 0, 0), '');
|
|
}
|
|
|
|
// Test with pool-allocated buffer (has non-zero byteOffset)
|
|
{
|
|
const poolBuf = Buffer.from('test data for hex encoding');
|
|
assert.strictEqual(
|
|
poolBuf.toString('hex'),
|
|
Buffer.from('test data for hex encoding').toString('hex')
|
|
);
|
|
assert.strictEqual(
|
|
poolBuf.toString('hex', 5, 9),
|
|
Buffer.from('data').toString('hex')
|
|
);
|
|
}
|
|
|
|
// Try toString() with an object as an encoding
|
|
assert.strictEqual(rangeBuffer.toString({ toString: function() {
|
|
return 'ascii';
|
|
} }), 'abc');
|
|
|
|
// Try toString() with 0 and null as the encoding
|
|
assert.throws(() => {
|
|
rangeBuffer.toString(0, 1, 2);
|
|
}, {
|
|
code: 'ERR_UNKNOWN_ENCODING',
|
|
name: 'TypeError',
|
|
message: 'Unknown encoding: 0'
|
|
});
|
|
assert.throws(() => {
|
|
rangeBuffer.toString(null, 1, 2);
|
|
}, {
|
|
code: 'ERR_UNKNOWN_ENCODING',
|
|
name: 'TypeError',
|
|
message: 'Unknown encoding: null'
|
|
});
|