2c4356cedfPort the domain module from createHook (async_hooks) to AsyncLocalStorage using the AsyncContextFrame-based implementation. Key changes: - Use AsyncLocalStorage for domain context propagation instead of async_hooks.createHook() - Lazy initialization that triggers AsyncContextFrame prototype swap on first domain use - Use enterWith instead of ALS.run() so domain context is NOT automatically restored on exception - this matches the original domain.run() behavior where exit() only runs on success - Add ERR_ASYNC_RESOURCE_DOMAIN_REMOVED error for AsyncResource.domain - Update DEP0097 to End-of-Life status - Remove tests that relied on the removed MakeCallback domain property The domain module now uses the AsyncContextFrame version of AsyncLocalStorage directly for proper context propagation across async boundaries. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: https://github.com/nodejs/node/pull/61095 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
85 lines
2.8 KiB
JavaScript
85 lines
2.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../../common');
|
|
const assert = require('assert');
|
|
const binding = require(`./build/${common.buildType}/binding`);
|
|
const makeCallback = binding.makeCallback;
|
|
|
|
// Make sure that using MakeCallback allows the error to propagate.
|
|
assert.throws(function() {
|
|
makeCallback({}, function() {
|
|
throw new Error('hi from domain error');
|
|
});
|
|
}, /^Error: hi from domain error$/);
|
|
|
|
|
|
// Check the execution order of the nextTickQueue and MicrotaskQueue in
|
|
// relation to running multiple MakeCallback's from bootstrap,
|
|
// node::MakeCallback() and node::AsyncWrap::MakeCallback().
|
|
// TODO(trevnorris): Is there a way to verify this is being run during
|
|
// bootstrap?
|
|
(function verifyExecutionOrder(arg) {
|
|
const results = [];
|
|
|
|
// Processing of the MicrotaskQueue is manually handled by node. They are not
|
|
// processed until after the nextTickQueue has been processed.
|
|
Promise.resolve(1).then(common.mustCall(function() {
|
|
results.push(7);
|
|
}));
|
|
|
|
// The nextTick should run after all immediately invoked calls.
|
|
process.nextTick(common.mustCall(function() {
|
|
results.push(3);
|
|
|
|
// Run same test again but while processing the nextTickQueue to make sure
|
|
// the following MakeCallback call breaks in the middle of processing the
|
|
// queue and allows the script to run normally.
|
|
process.nextTick(common.mustCall(function() {
|
|
results.push(6);
|
|
}));
|
|
|
|
makeCallback({}, common.mustCall(function() {
|
|
results.push(4);
|
|
}));
|
|
|
|
results.push(5);
|
|
}));
|
|
|
|
results.push(0);
|
|
|
|
// MakeCallback is calling the function immediately, but should then detect
|
|
// that a script is already in the middle of execution and return before
|
|
// either the nextTickQueue or MicrotaskQueue are processed.
|
|
makeCallback({}, common.mustCall(function() {
|
|
results.push(1);
|
|
}));
|
|
|
|
// This should run before either the nextTickQueue or MicrotaskQueue are
|
|
// processed. Previously MakeCallback would not detect this circumstance
|
|
// and process them immediately.
|
|
results.push(2);
|
|
|
|
setImmediate(common.mustCall(function() {
|
|
for (let i = 0; i < results.length; i++) {
|
|
assert.strictEqual(results[i], i,
|
|
`verifyExecutionOrder(${arg}) results: ${results}`);
|
|
}
|
|
if (arg === 1) {
|
|
// The tests are first run on bootstrap during LoadEnvironment() in
|
|
// src/node.cc. Now run the tests through node::MakeCallback().
|
|
setImmediate(common.mustCall(function() {
|
|
makeCallback({}, common.mustCall(function() {
|
|
verifyExecutionOrder(2);
|
|
}));
|
|
}));
|
|
} else if (arg === 2) {
|
|
// Make sure there are no conflicts using node::MakeCallback()
|
|
// within timers.
|
|
setTimeout(common.mustCall(function() {
|
|
verifyExecutionOrder(3);
|
|
}), 10);
|
|
} else {
|
|
assert.strictEqual(arg, 3);
|
|
}
|
|
}));
|
|
}(1));
|