33bbf3751b
When V8 creates a context for snapshot building, it does not install Error.stackTraceLimit. As a result, error.stack would be undefined in the snapshot builder script unless users explicitly initialize Error.stackTraceLimit, which may be surprising. This patch initializes Error.stackTraceLimit based on the value of --stack-trace-limit to prevent the surprise. If users have modified Error.stackTraceLimit in the builder script, the modified value would be restored during deserialization. Otherwise, the fixed up limit would be deleted since V8 expects to find it unset and re-initialize it during snapshot deserialization. PR-URL: https://github.com/nodejs/node/pull/55121 Fixes: https://github.com/nodejs/node/issues/55100 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
24 lines
645 B
JavaScript
24 lines
645 B
JavaScript
|
|
const {
|
|
setDeserializeMainFunction,
|
|
} = require('v8').startupSnapshot;
|
|
|
|
console.log(`During snapshot building, Error.stackTraceLimit =`, Error.stackTraceLimit);
|
|
console.log(getError('During snapshot building', 30));
|
|
|
|
setDeserializeMainFunction(() => {
|
|
console.log(`After snapshot deserialization, Error.stackTraceLimit =`, Error.stackTraceLimit);
|
|
console.log(getError('After snapshot deserialization', 30));
|
|
});
|
|
|
|
function getError(message, depth) {
|
|
let counter = 1;
|
|
function recurse() {
|
|
if (counter++ < depth) {
|
|
return recurse();
|
|
}
|
|
const error = new Error(message);
|
|
return error.stack;
|
|
}
|
|
return recurse();
|
|
}
|