72d0e7e70b* eliminate pooling of Nghttp2Stream instances. After testing, the pooling is not having any tangible benefit and makes things more complicated. Simplify. Simplify. * refactor inbound headers * Enforce MAX_HEADERS_LIST setting and limit the number of header pairs accepted from the peer. Use the ENHANCE_YOUR_CALM error code when receiving either too many headers or too many octets. Use a vector to store the headers instead of a queue PR-URL: https://github.com/nodejs/node/pull/16676 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
34 lines
1 KiB
JavaScript
34 lines
1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
const assert = require('assert');
|
|
const {
|
|
NGHTTP2_ENHANCE_YOUR_CALM
|
|
} = http2.constants;
|
|
|
|
// By default, the maximum number of header fields allowed per
|
|
// block is 128, including the HTTP pseudo-header fields. The
|
|
// minimum value for servers is 4, setting this to any value
|
|
// less than 4 will still leave the minimum to 4.
|
|
const server = http2.createServer({ maxHeaderListPairs: 0 });
|
|
server.on('stream', common.mustNotCall());
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
const req = client.request({ foo: 'bar' });
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
type: Error,
|
|
message: 'Stream closed with error code 11'
|
|
}));
|
|
req.on('streamClosed', common.mustCall((code) => {
|
|
assert.strictEqual(code, NGHTTP2_ENHANCE_YOUR_CALM);
|
|
server.close();
|
|
client.destroy();
|
|
}));
|
|
|
|
}));
|