The initials of expected in TypeError[ERR_INVALID_ARG_TYPE] are inconsistent. This change is to unify them. PR-URL: https://github.com/nodejs/node/pull/16401 Fixes: https://github.com/nodejs/node/issues/16383 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
47 lines
1.2 KiB
JavaScript
47 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const dgram = require('dgram');
|
|
const dns = require('dns');
|
|
|
|
{
|
|
// Verify that the provided lookup function is called.
|
|
const lookup = common.mustCall((host, family, callback) => {
|
|
dns.lookup(host, family, callback);
|
|
});
|
|
|
|
const socket = dgram.createSocket({ type: 'udp4', lookup });
|
|
|
|
socket.bind(common.mustCall(() => {
|
|
socket.close();
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Verify that lookup defaults to dns.lookup().
|
|
const originalLookup = dns.lookup;
|
|
|
|
dns.lookup = common.mustCall((host, family, callback) => {
|
|
dns.lookup = originalLookup;
|
|
originalLookup(host, family, callback);
|
|
});
|
|
|
|
const socket = dgram.createSocket({ type: 'udp4' });
|
|
|
|
socket.bind(common.mustCall(() => {
|
|
socket.close();
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Verify that non-functions throw.
|
|
[null, true, false, 0, 1, NaN, '', 'foo', {}, Symbol()].forEach((value) => {
|
|
assert.throws(() => {
|
|
dgram.createSocket({ type: 'udp4', lookup: value });
|
|
}, common.expectsError({
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "lookup" argument must be of type Function'
|
|
}));
|
|
});
|
|
}
|