1f32d9ef5b* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
60 lines
2.2 KiB
JavaScript
60 lines
2.2 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const util = require('util');
|
|
|
|
assert.ok(process.stdout.writable);
|
|
assert.ok(process.stderr.writable);
|
|
|
|
const strings = [];
|
|
common.hijackStdout(function(data) {
|
|
strings.push(data);
|
|
});
|
|
common.hijackStderr(common.mustNotCall('stderr.write must not be called'));
|
|
|
|
const tests = [
|
|
{input: 'foo', output: 'foo'},
|
|
{input: undefined, output: 'undefined'},
|
|
{input: null, output: 'null'},
|
|
{input: false, output: 'false'},
|
|
{input: 42, output: '42'},
|
|
{input: function() {}, output: '[Function: input]'},
|
|
{input: parseInt('not a number', 10), output: 'NaN'},
|
|
{input: {answer: 42}, output: '{ answer: 42 }'},
|
|
{input: [1, 2, 3], output: '[ 1, 2, 3 ]'}
|
|
];
|
|
|
|
// test util.log()
|
|
const re = /[0-9]{1,2} [A-Z][a-z]{2} [0-9]{2}:[0-9]{2}:[0-9]{2} - (.+)$/;
|
|
tests.forEach(function(test) {
|
|
util.log(test.input);
|
|
const result = strings.shift().trim();
|
|
const match = re.exec(result);
|
|
assert.ok(match);
|
|
assert.strictEqual(match[1], test.output);
|
|
});
|
|
|
|
assert.strictEqual(process.stdout.writeTimes, tests.length);
|
|
|
|
common.restoreStdout();
|