1f32d9ef5b* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
46 lines
1.3 KiB
JavaScript
46 lines
1.3 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
function doSetTimeout(callback, after) {
|
|
return function() {
|
|
setTimeout(callback, after);
|
|
};
|
|
}
|
|
|
|
const errMessage = /"callback" argument must be a function/;
|
|
|
|
assert.throws(doSetTimeout('foo'), errMessage);
|
|
assert.throws(doSetTimeout({foo: 'bar'}), errMessage);
|
|
assert.throws(doSetTimeout(), errMessage);
|
|
assert.throws(doSetTimeout(undefined, 0), errMessage);
|
|
assert.throws(doSetTimeout(null, 0), errMessage);
|
|
assert.throws(doSetTimeout(false, 0), errMessage);
|
|
|
|
|
|
function doSetInterval(callback, after) {
|
|
return function() {
|
|
setInterval(callback, after);
|
|
};
|
|
}
|
|
|
|
assert.throws(doSetInterval('foo'), errMessage);
|
|
assert.throws(doSetInterval({foo: 'bar'}), errMessage);
|
|
assert.throws(doSetInterval(), errMessage);
|
|
assert.throws(doSetInterval(undefined, 0), errMessage);
|
|
assert.throws(doSetInterval(null, 0), errMessage);
|
|
assert.throws(doSetInterval(false, 0), errMessage);
|
|
|
|
|
|
function doSetImmediate(callback, after) {
|
|
return function() {
|
|
setImmediate(callback, after);
|
|
};
|
|
}
|
|
|
|
assert.throws(doSetImmediate('foo'), errMessage);
|
|
assert.throws(doSetImmediate({foo: 'bar'}), errMessage);
|
|
assert.throws(doSetImmediate(), errMessage);
|
|
assert.throws(doSetImmediate(undefined, 0), errMessage);
|
|
assert.throws(doSetImmediate(null, 0), errMessage);
|
|
assert.throws(doSetImmediate(false, 0), errMessage);
|