1f32d9ef5b* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
74 lines
2.6 KiB
JavaScript
74 lines
2.6 KiB
JavaScript
// Flags: --no-warnings
|
|
// The flag suppresses stderr output but the warning event will still emit
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const testMsg = 'A Warning';
|
|
const testCode = 'CODE001';
|
|
const testDetail = 'Some detail';
|
|
const testType = 'CustomWarning';
|
|
|
|
process.on('warning', common.mustCall((warning) => {
|
|
assert(warning);
|
|
assert(/^(?:Warning|CustomWarning)/.test(warning.name));
|
|
assert.strictEqual(warning.message, testMsg);
|
|
if (warning.code) assert.strictEqual(warning.code, testCode);
|
|
if (warning.detail) assert.strictEqual(warning.detail, testDetail);
|
|
}, 15));
|
|
|
|
class CustomWarning extends Error {
|
|
constructor() {
|
|
super();
|
|
this.name = testType;
|
|
this.message = testMsg;
|
|
this.code = testCode;
|
|
Error.captureStackTrace(this, CustomWarning);
|
|
}
|
|
}
|
|
|
|
[
|
|
[testMsg],
|
|
[testMsg, testType],
|
|
[testMsg, CustomWarning],
|
|
[testMsg, testType, CustomWarning],
|
|
[testMsg, testType, testCode],
|
|
[testMsg, { type: testType }],
|
|
[testMsg, { type: testType, code: testCode }],
|
|
[testMsg, { type: testType, code: testCode, detail: testDetail }],
|
|
[new CustomWarning()],
|
|
// detail will be ignored for the following. No errors thrown
|
|
[testMsg, { type: testType, code: testCode, detail: true }],
|
|
[testMsg, { type: testType, code: testCode, detail: [] }],
|
|
[testMsg, { type: testType, code: testCode, detail: null }],
|
|
[testMsg, { type: testType, code: testCode, detail: 1 }]
|
|
].forEach((i) => {
|
|
assert.doesNotThrow(() => process.emitWarning.apply(null, i));
|
|
});
|
|
|
|
const warningNoToString = new CustomWarning();
|
|
warningNoToString.toString = null;
|
|
process.emitWarning(warningNoToString);
|
|
|
|
const warningThrowToString = new CustomWarning();
|
|
warningThrowToString.toString = function() {
|
|
throw new Error('invalid toString');
|
|
};
|
|
process.emitWarning(warningThrowToString);
|
|
|
|
const expectedError =
|
|
common.expectsError({code: 'ERR_INVALID_ARG_TYPE', type: TypeError});
|
|
|
|
// TypeError is thrown on invalid input
|
|
assert.throws(() => process.emitWarning(1), expectedError);
|
|
assert.throws(() => process.emitWarning({}), expectedError);
|
|
assert.throws(() => process.emitWarning(true), expectedError);
|
|
assert.throws(() => process.emitWarning([]), expectedError);
|
|
assert.throws(() => process.emitWarning('', '', {}), expectedError);
|
|
assert.throws(() => process.emitWarning('', 1), expectedError);
|
|
assert.throws(() => process.emitWarning('', '', 1), expectedError);
|
|
assert.throws(() => process.emitWarning('', true), expectedError);
|
|
assert.throws(() => process.emitWarning('', '', true), expectedError);
|
|
assert.throws(() => process.emitWarning('', []), expectedError);
|
|
assert.throws(() => process.emitWarning('', '', []), expectedError);
|