Fix the logic of resetting the socket timeout of keep-alive HTTP connections and add two tests: * `test-http-server-keep-alive-timeout-slow-server` is a regression test for GH-13391. It ensures that the server-side keep-alive timeout will not fire during processing of a request. * `test-http-server-keep-alive-timeout-slow-client-headers` ensures that the regular socket timeout is restored as soon as a client starts sending a new request, not as soon as the whole message is received, so that the keep-alive timeout will not fire while, e.g., the client is sending large cookies. Refs: https://github.com/nodejs/node/pull/2534 Fixes: https://github.com/nodejs/node/issues/13391 PR-URL: https://github.com/nodejs/node/pull/13549 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
57 lines
1.5 KiB
JavaScript
57 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
const net = require('net');
|
|
|
|
const server = http.createServer(common.mustCall((req, res) => {
|
|
res.end();
|
|
}, 2));
|
|
|
|
server.keepAliveTimeout = common.platformTimeout(100);
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
const socket = net.connect({ port }, common.mustCall(() => {
|
|
request(common.mustCall(() => {
|
|
// Make a second request on the same socket, after the keep-alive timeout
|
|
// has been set on the server side.
|
|
request(common.mustCall());
|
|
}));
|
|
}));
|
|
|
|
server.on('timeout', common.mustCall(() => {
|
|
socket.end();
|
|
server.close();
|
|
}));
|
|
|
|
function request(callback) {
|
|
socket.setEncoding('utf8');
|
|
socket.on('data', onData);
|
|
let response = '';
|
|
|
|
// Simulate a client that sends headers slowly (with a period of inactivity
|
|
// that is longer than the keep-alive timeout).
|
|
socket.write('GET / HTTP/1.1\r\n' +
|
|
`Host: localhost:${port}\r\n`);
|
|
setTimeout(() => {
|
|
socket.write('Connection: keep-alive\r\n' +
|
|
'\r\n');
|
|
}, common.platformTimeout(300));
|
|
|
|
function onData(chunk) {
|
|
response += chunk;
|
|
if (chunk.includes('\r\n')) {
|
|
socket.removeListener('data', onData);
|
|
onHeaders();
|
|
}
|
|
}
|
|
|
|
function onHeaders() {
|
|
assert.ok(response.includes('HTTP/1.1 200 OK\r\n'));
|
|
assert.ok(response.includes('Connection: keep-alive\r\n'));
|
|
callback();
|
|
}
|
|
}
|
|
}));
|