gitroo-admin/node
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
node/lib/internal
History
Exact
Fedor Indutny eff771f399 tickprocessor: apply c++filt manually on mac 
`/bin/sh -c` trick wasn't working for several reasons:

* `/bin/sh -c "..."` expects the first argument after `"..."` to be a
  `$0`, not a `$1`. Previously `-n` wasn't passed to `nm` because of
  this, and many symbols were ordered improperly
* `c++filt` was applied not only to the names of the functions but to
  their `nm` prefixes like `t` and `a` (`t xxx` turns into
  `unsigned char xxx`).

Instead of applying `c++filt` wide and using `sh -c`, execute `nm` as
requested by `deps/v8/tools/tickprocessor.js` and apply `c++filt` to all
matching entries manually.

Included test demonstrates where previous approach failed: all builtins
were merged into `v8::internal::Builtins::~Builtins`, because they were
prefixed by `t` in `nm` output.

PR-URL: https://github.com/nodejs/node/pull/8480
Reviewed-By: Matthew Loring <mattloring@google.com>
2016-09-13 17:04:47 -07:00
..
process promise: warn on unhandled rejections 2016-08-31 10:35:13 -07:00
streams buffer: introduce latin1 encoding term 2016-08-08 21:37:37 +02:00
bootstrap_node.js deps: v8_inspector: console support 2016-08-15 09:50:18 -04:00
child_process.js tools: fix new-parens violations 2016-09-13 17:04:46 -07:00
cluster.js cluster: remove handles when disconnecting worker 2015-11-06 23:02:11 +01:00
freelist.js lib: freelist: use .pop() for allocation 2016-03-02 09:24:24 -08:00
linkedlist.js timers: optimize setImmediate() 2016-07-05 22:36:43 +02:00
module.js repl: keep the built-in modules non-enumerable 2016-04-26 12:16:13 -07:00
net.js net: Validate port in createServer().listen() 2016-04-26 12:16:28 -07:00
process.js src: refactor require('constants') 2016-07-05 22:09:12 +02:00
readline.js readline: keypress trigger for escape character 2016-08-20 10:02:10 -05:00
readme.md doc: add internal modules notice 2015-08-25 11:58:50 -04:00
repl.js repl: don't override all internal repl defaults 2016-08-10 12:54:22 -04:00
socket_list.js child_process: refactor self=this in socket_list 2016-03-27 12:51:33 +03:00
util.js buffer,string_decoder: consolidate encoding validation logic 2016-09-13 16:13:09 -07:00
v8_prof_polyfill.js tickprocessor: apply c++filt manually on mac 2016-09-13 17:04:47 -07:00
v8_prof_processor.js tickprocessor: apply c++filt manually on mac 2016-09-13 17:04:47 -07:00

readme.md

Internal Modules

The modules in lib/internal are intended for internal use in Node.js core only, and are not accessible with require() from user modules. These are subject to change at any time. Reliance on these modules outside of core is not supported in any way.