edb29b8096
There has been occasional nits for spacing in object literals in PRs but
the project does not lint for it and it is not always handled
consistently in the existing code, even on adjacent lines of a file.
This change enables a linting rule requiring no space between the key
and the colon, and requiring at least one space (but allowing for more
so property values can be lined up if desired) between the colon and the
value. This appears to be the most common style used in the current code
base.
Example code the complies with lint rule:
myObj = { foo: 'bar' };
Examples that do not comply with the lint rule:
myObj = { foo : 'bar' };
myObj = { foo:'bar' };
PR-URL: https://github.com/nodejs/node/pull/6592
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
74 lines
2.3 KiB
JavaScript
74 lines
2.3 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
var assert = require('assert');
|
|
|
|
var vm = require('vm');
|
|
var Script = vm.Script;
|
|
var script = new Script('"passed";');
|
|
|
|
console.error('run in a new empty context');
|
|
var context = vm.createContext();
|
|
var result = script.runInContext(context);
|
|
assert.equal('passed', result);
|
|
|
|
console.error('create a new pre-populated context');
|
|
context = vm.createContext({'foo': 'bar', 'thing': 'lala'});
|
|
assert.equal('bar', context.foo);
|
|
assert.equal('lala', context.thing);
|
|
|
|
console.error('test updating context');
|
|
script = new Script('foo = 3;');
|
|
result = script.runInContext(context);
|
|
assert.equal(3, context.foo);
|
|
assert.equal('lala', context.thing);
|
|
|
|
// Issue GH-227:
|
|
assert.throws(function() {
|
|
vm.runInNewContext('', null, 'some.js');
|
|
}, TypeError);
|
|
|
|
// Issue GH-1140:
|
|
console.error('test runInContext signature');
|
|
var gh1140Exception;
|
|
try {
|
|
vm.runInContext('throw new Error()', context, 'expected-filename.js');
|
|
}
|
|
catch (e) {
|
|
gh1140Exception = e;
|
|
assert.ok(/expected-filename/.test(e.stack),
|
|
'expected appearance of filename in Error stack');
|
|
}
|
|
assert.ok(gh1140Exception,
|
|
'expected exception from runInContext signature test');
|
|
|
|
// GH-558, non-context argument segfaults / raises assertion
|
|
[undefined, null, 0, 0.0, '', {}, []].forEach(function(e) {
|
|
assert.throws(function() { script.runInContext(e); }, TypeError);
|
|
assert.throws(function() { vm.runInContext('', e); }, TypeError);
|
|
});
|
|
|
|
// Issue GH-693:
|
|
console.error('test RegExp as argument to assert.throws');
|
|
script = vm.createScript('var assert = require(\'assert\'); assert.throws(' +
|
|
'function() { throw "hello world"; }, /hello/);',
|
|
'some.js');
|
|
script.runInNewContext({ require: require });
|
|
|
|
// Issue GH-7529
|
|
script = vm.createScript('delete b');
|
|
var ctx = {};
|
|
Object.defineProperty(ctx, 'b', { configurable: false });
|
|
ctx = vm.createContext(ctx);
|
|
assert.equal(script.runInContext(ctx), false);
|
|
|
|
// Error on the first line of a module should
|
|
// have the correct line and column number
|
|
assert.throws(function() {
|
|
vm.runInContext('throw new Error()', context, {
|
|
filename: 'expected-filename.js',
|
|
lineOffset: 32,
|
|
columnOffset: 123
|
|
});
|
|
}, function(err) {
|
|
return /expected-filename.js:33:130/.test(err.stack);
|
|
}, 'Expected appearance of proper offset in Error stack');
|