229a03f1bb
`freeParser` deallocates `Parser` instances early if they do not fit
into the free list. This does not play well with recent socket
consumption change, because it will try to deallocate the parser while
executing on its stack.
Regression was introduced in: 1bc4468
Fix: https://github.com/nodejs/node/issues/2928
PR-URL: https://github.com/nodejs/node/pull/2956
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
51 lines
1.3 KiB
JavaScript
51 lines
1.3 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const httpCommon = require('_http_common');
|
|
const HTTPParser = process.binding('http_parser').HTTPParser;
|
|
const net = require('net');
|
|
|
|
const PARALLEL = 30;
|
|
const COUNT = httpCommon.parsers.max + 100;
|
|
|
|
const parsers = new Array(COUNT);
|
|
for (var i = 0; i < parsers.length; i++)
|
|
parsers[i] = httpCommon.parsers.alloc();
|
|
|
|
var gotRequests = 0;
|
|
var gotResponses = 0;
|
|
|
|
function execAndClose() {
|
|
process.stdout.write('.');
|
|
if (parsers.length === 0)
|
|
return;
|
|
|
|
const parser = parsers.pop();
|
|
parser.reinitialize(HTTPParser.RESPONSE);
|
|
const socket = net.connect(common.PORT);
|
|
parser.consume(socket._handle._externalStream);
|
|
|
|
parser.onIncoming = function onIncoming() {
|
|
process.stdout.write('+');
|
|
gotResponses++;
|
|
parser.unconsume(socket._handle._externalStream);
|
|
httpCommon.freeParser(parser);
|
|
socket.destroy();
|
|
setImmediate(execAndClose);
|
|
};
|
|
}
|
|
|
|
var server = net.createServer(function(c) {
|
|
if (++gotRequests === COUNT)
|
|
server.close();
|
|
c.end('HTTP/1.1 200 OK\r\n\r\n', function() {
|
|
c.destroySoon();
|
|
});
|
|
}).listen(common.PORT, function() {
|
|
for (var i = 0; i < PARALLEL; i++)
|
|
execAndClose();
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.equal(gotResponses, COUNT);
|
|
});
|