d94a70ec51
test-domain-exit-dispose-again had been written for node v0.10.x, and was using the fact that callbacks scheduled with `process.nextTick` wouldn't run if the domain attached to it was disposed. This is not longer the case, and as a result the test would not catch any regression: it would always pass. This change rewrites that test to check that the current domain is cleared properly when processing the rest of the timers list if a timer's callback throws an error. This makes the test fail without the original fix, and pass with the original fix, as expected. PR: #3990 PR-URL: https://github.com/nodejs/node/pull/3990 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
39 lines
1.2 KiB
JavaScript
39 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const domain = require('domain');
|
|
|
|
// Use the same timeout value so that both timers' callbacks are called during
|
|
// the same invocation of the underlying native timer's callback (listOnTimeout
|
|
// in lib/timers.js).
|
|
setTimeout(err, 50);
|
|
setTimeout(common.mustCall(secondTimer), 50);
|
|
|
|
function err() {
|
|
const d = domain.create();
|
|
d.on('error', handleDomainError);
|
|
d.run(err2);
|
|
|
|
function err2() {
|
|
// this function doesn't exist, and throws an error as a result.
|
|
err3();
|
|
}
|
|
|
|
function handleDomainError(e) {
|
|
// In the domain's error handler, the current active domain should be the
|
|
// domain within which the error was thrown.
|
|
assert.equal(process.domain, d);
|
|
}
|
|
}
|
|
|
|
function secondTimer() {
|
|
// secondTimer was scheduled before any domain had been created, so its
|
|
// callback should not have any active domain set when it runs.
|
|
// Do not use assert here, as it throws errors and if a domain with an error
|
|
// handler is active, then asserting wouldn't make the test fail.
|
|
if (process.domain !== null) {
|
|
console.log('process.domain should be null, but instead is:',
|
|
process.domain);
|
|
process.exit(1);
|
|
}
|
|
}
|