7added3b39
In fs.readFile, if an encoding is specified and toString fails, do not throw an error. Instead, pass the error to the callback. Fixes: https://github.com/nodejs/node/issues/2767 PR-URL: https://github.com/nodejs/node/pull/3485 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
52 lines
1.1 KiB
JavaScript
52 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const kStringMaxLength = process.binding('buffer').kStringMaxLength;
|
|
|
|
common.refreshTmpDir();
|
|
|
|
const file = path.join(common.tmpDir, 'toobig.txt');
|
|
const stream = fs.createWriteStream(file, {
|
|
flags: 'a'
|
|
});
|
|
|
|
const size = kStringMaxLength / 200;
|
|
const a = new Buffer(size).fill('a');
|
|
|
|
for (var i = 0; i < 201; i++) {
|
|
stream.write(a);
|
|
}
|
|
|
|
stream.end();
|
|
stream.on('finish', common.mustCall(function() {
|
|
// make sure that the toString does not throw an error
|
|
fs.readFile(file, 'utf8', common.mustCall(function(err, buf) {
|
|
assert.ok(err instanceof Error);
|
|
assert.strictEqual('toString failed', err.message);
|
|
}));
|
|
}));
|
|
|
|
function destroy() {
|
|
try {
|
|
fs.unlinkSync(file);
|
|
} catch (err) {
|
|
// it may not exist
|
|
}
|
|
}
|
|
|
|
process.on('exit', destroy);
|
|
|
|
process.on('SIGINT', function() {
|
|
destroy();
|
|
process.exit();
|
|
});
|
|
|
|
// To make sure we don't leave a very large file
|
|
// on test machines in the event this test fails.
|
|
process.on('uncaughtException', function(err) {
|
|
destroy();
|
|
throw err;
|
|
});
|