19907c27a6Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
51 lines
1.3 KiB
JavaScript
51 lines
1.3 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const childProcess = require('child_process');
|
|
const fs = require('fs');
|
|
|
|
const scriptString = path.join(common.fixturesDir, 'print-chars.js');
|
|
const scriptBuffer = path.join(common.fixturesDir,
|
|
'print-chars-from-buffer.js');
|
|
const tmpFile = path.join(common.tmpDir, 'stdout.txt');
|
|
|
|
common.refreshTmpDir();
|
|
|
|
function test(size, useBuffer, cb) {
|
|
var cmd = '"' + process.argv[0] + '"' +
|
|
' ' +
|
|
'"' + (useBuffer ? scriptBuffer : scriptString) + '"' +
|
|
' ' +
|
|
size +
|
|
' > ' +
|
|
'"' + tmpFile + '"';
|
|
|
|
try {
|
|
fs.unlinkSync(tmpFile);
|
|
} catch (e) {}
|
|
|
|
console.log(`${size} chars to ${tmpFile}...`);
|
|
|
|
childProcess.exec(cmd, common.mustCall(function(err) {
|
|
if (err) throw err;
|
|
|
|
console.log('done!');
|
|
|
|
var stat = fs.statSync(tmpFile);
|
|
|
|
console.log(`${tmpFile} has ${stat.size} bytes`);
|
|
|
|
assert.strictEqual(size, stat.size);
|
|
fs.unlinkSync(tmpFile);
|
|
|
|
cb();
|
|
}));
|
|
}
|
|
|
|
test(1024 * 1024, false, common.mustCall(function() {
|
|
console.log('Done printing with string');
|
|
test(1024 * 1024, true, common.mustCall(function() {
|
|
console.log('Done printing with buffer');
|
|
}));
|
|
}));
|