19907c27a6Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
90 lines
2.3 KiB
JavaScript
90 lines
2.3 KiB
JavaScript
'use strict';
|
|
var assert = require('assert');
|
|
var common = require('../common');
|
|
var fork = require('child_process').fork;
|
|
var net = require('net');
|
|
|
|
// child
|
|
if (process.argv[2] === 'child') {
|
|
|
|
// Check that the 'disconnect' event is deferred to the next event loop tick.
|
|
var disconnect = process.disconnect;
|
|
process.disconnect = function() {
|
|
disconnect.apply(this, arguments);
|
|
// If the event is emitted synchronously, we're too late by now.
|
|
process.once('disconnect', common.mustCall(disconnectIsNotAsync));
|
|
// The funky function name makes it show up legible in mustCall errors.
|
|
function disconnectIsNotAsync() {}
|
|
};
|
|
|
|
var server = net.createServer();
|
|
|
|
server.on('connection', function(socket) {
|
|
|
|
socket.resume();
|
|
|
|
process.on('disconnect', function() {
|
|
socket.end((process.connected).toString());
|
|
});
|
|
|
|
// when the socket is closed, we will close the server
|
|
// allowing the process to self terminate
|
|
socket.on('end', function() {
|
|
server.close();
|
|
});
|
|
|
|
socket.write('ready');
|
|
});
|
|
|
|
// when the server is ready tell parent
|
|
server.on('listening', function() {
|
|
process.send({ msg: 'ready', port: server.address().port });
|
|
});
|
|
|
|
server.listen(0);
|
|
|
|
} else {
|
|
// testcase
|
|
var child = fork(process.argv[1], ['child']);
|
|
|
|
var childFlag = false;
|
|
var parentFlag = false;
|
|
|
|
// when calling .disconnect the event should emit
|
|
// and the disconnected flag should be true.
|
|
child.on('disconnect', common.mustCall(function() {
|
|
parentFlag = child.connected;
|
|
}));
|
|
|
|
// the process should also self terminate without using signals
|
|
child.on('exit', common.mustCall(function() {}));
|
|
|
|
// when child is listening
|
|
child.on('message', function(obj) {
|
|
if (obj && obj.msg === 'ready') {
|
|
|
|
// connect to child using TCP to know if disconnect was emitted
|
|
var socket = net.connect(obj.port);
|
|
|
|
socket.on('data', function(data) {
|
|
data = data.toString();
|
|
|
|
// ready to be disconnected
|
|
if (data === 'ready') {
|
|
child.disconnect();
|
|
assert.throws(child.disconnect.bind(child), Error);
|
|
return;
|
|
}
|
|
|
|
// disconnect is emitted
|
|
childFlag = (data === 'true');
|
|
});
|
|
|
|
}
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.equal(childFlag, false);
|
|
assert.equal(parentFlag, false);
|
|
});
|
|
}
|