d795301025
common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. The main tradeoff for this bit of code churn is that it gets the code base most of the way to being able to enable the no-unused-vars rule in eslint. (The non-tooling benefit is that it lessens cognitive load when reading tests as it is an immediate indication that none of the functions or properties in common.js will be used by the test.) PR-URL: https://github.com/nodejs/node/pull/4563 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
64 lines
1.3 KiB
JavaScript
64 lines
1.3 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
var assert = require('assert');
|
|
var stream = require('stream');
|
|
var str = 'asdfasdfasdfasdfasdf';
|
|
|
|
var r = new stream.Readable({
|
|
highWaterMark: 5,
|
|
encoding: 'utf8'
|
|
});
|
|
|
|
var reads = 0;
|
|
var eofed = false;
|
|
var ended = false;
|
|
|
|
r._read = function(n) {
|
|
if (reads === 0) {
|
|
setTimeout(function() {
|
|
r.push(str);
|
|
});
|
|
reads++;
|
|
} else if (reads === 1) {
|
|
var ret = r.push(str);
|
|
assert.equal(ret, false);
|
|
reads++;
|
|
} else {
|
|
assert(!eofed);
|
|
eofed = true;
|
|
r.push(null);
|
|
}
|
|
};
|
|
|
|
r.on('end', function() {
|
|
ended = true;
|
|
});
|
|
|
|
// push some data in to start.
|
|
// we've never gotten any read event at this point.
|
|
var ret = r.push(str);
|
|
// should be false. > hwm
|
|
assert(!ret);
|
|
var chunk = r.read();
|
|
assert.equal(chunk, str);
|
|
chunk = r.read();
|
|
assert.equal(chunk, null);
|
|
|
|
r.once('readable', function() {
|
|
// this time, we'll get *all* the remaining data, because
|
|
// it's been added synchronously, as the read WOULD take
|
|
// us below the hwm, and so it triggered a _read() again,
|
|
// which synchronously added more, which we then return.
|
|
chunk = r.read();
|
|
assert.equal(chunk, str + str);
|
|
|
|
chunk = r.read();
|
|
assert.equal(chunk, null);
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert(eofed);
|
|
assert(ended);
|
|
assert.equal(reads, 2);
|
|
console.log('ok');
|
|
});
|