d795301025
common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. The main tradeoff for this bit of code churn is that it gets the code base most of the way to being able to enable the no-unused-vars rule in eslint. (The non-tooling benefit is that it lessens cognitive load when reading tests as it is an immediate indication that none of the functions or properties in common.js will be used by the test.) PR-URL: https://github.com/nodejs/node/pull/4563 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
33 lines
927 B
JavaScript
33 lines
927 B
JavaScript
'use strict';
|
|
require('../common');
|
|
var assert = require('assert');
|
|
var http = require('http');
|
|
|
|
// sending `agent: false` when `port: null` is also passed in (i.e. the result
|
|
// of a `url.parse()` call with the default port used, 80 or 443), should not
|
|
// result in an assertion error...
|
|
var opts = {
|
|
host: '127.0.0.1',
|
|
port: null,
|
|
path: '/',
|
|
method: 'GET',
|
|
agent: false
|
|
};
|
|
|
|
var good = false;
|
|
process.on('exit', function() {
|
|
assert(good, 'expected either an "error" or "response" event');
|
|
});
|
|
|
|
// we just want an "error" (no local HTTP server on port 80) or "response"
|
|
// to happen (user happens ot have HTTP server running on port 80).
|
|
// As long as the process doesn't crash from a C++ assertion then we're good.
|
|
var req = http.request(opts);
|
|
req.on('response', function(res) {
|
|
good = true;
|
|
});
|
|
req.on('error', function(err) {
|
|
// an "error" event is ok, don't crash the process
|
|
good = true;
|
|
});
|
|
req.end();
|