node/test/parallel/test-dns.js
Michaël Zasso f5b952b221 test: refactor and fix test-dns
* More precise length assertion.
* Fix incorrect use of string instead of RegExp in `throws` assertions.
* Add missing RegExp to `throws` assertions.

PR-URL: https://github.com/nodejs/node/pull/9811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2016-12-27 15:07:02 -05:00

167 lines
3.7 KiB
JavaScript

'use strict';
require('../common');
const assert = require('assert');
const dns = require('dns');
var existing = dns.getServers();
assert(existing.length > 0);
function noop() {}
var goog = [
'8.8.8.8',
'8.8.4.4',
];
assert.doesNotThrow(function() { dns.setServers(goog); });
assert.deepEqual(dns.getServers(), goog);
assert.throws(function() { dns.setServers(['foobar']); },
/^Error: IP address is not properly formatted: foobar$/);
assert.deepEqual(dns.getServers(), goog);
var goog6 = [
'2001:4860:4860::8888',
'2001:4860:4860::8844',
];
assert.doesNotThrow(function() { dns.setServers(goog6); });
assert.deepEqual(dns.getServers(), goog6);
goog6.push('4.4.4.4');
dns.setServers(goog6);
assert.deepEqual(dns.getServers(), goog6);
var ports = [
'4.4.4.4:53',
'[2001:4860:4860::8888]:53',
];
var portsExpected = [
'4.4.4.4',
'2001:4860:4860::8888',
];
dns.setServers(ports);
assert.deepEqual(dns.getServers(), portsExpected);
assert.doesNotThrow(function() { dns.setServers([]); });
assert.deepEqual(dns.getServers(), []);
assert.throws(function() {
dns.resolve('test.com', [], noop);
}, function(err) {
return !(err instanceof TypeError);
}, 'Unexpected error');
// dns.lookup should accept falsey and string values
const errorReg =
/^TypeError: invalid arguments: hostname must be a string or falsey$/;
assert.throws(function() {
dns.lookup({}, noop);
}, errorReg);
assert.throws(function() {
dns.lookup([], noop);
}, errorReg);
assert.throws(function() {
dns.lookup(true, noop);
}, errorReg);
assert.throws(function() {
dns.lookup(1, noop);
}, errorReg);
assert.throws(function() {
dns.lookup(noop, noop);
}, errorReg);
assert.doesNotThrow(function() {
dns.lookup('', noop);
});
assert.doesNotThrow(function() {
dns.lookup(null, noop);
});
assert.doesNotThrow(function() {
dns.lookup(undefined, noop);
});
assert.doesNotThrow(function() {
dns.lookup(0, noop);
});
assert.doesNotThrow(function() {
dns.lookup(NaN, noop);
});
/*
* Make sure that dns.lookup throws if hints does not represent a valid flag.
* (dns.V4MAPPED | dns.ADDRCONFIG) + 1 is invalid because:
* - it's different from dns.V4MAPPED and dns.ADDRCONFIG.
* - it's different from them bitwise ored.
* - it's different from 0.
* - it's an odd number different than 1, and thus is invalid, because
* flags are either === 1 or even.
*/
assert.throws(function() {
dns.lookup('www.google.com', { hints: (dns.V4MAPPED | dns.ADDRCONFIG) + 1 },
noop);
}, /^TypeError: invalid argument: hints must use valid flags$/);
assert.throws(function() {
dns.lookup('www.google.com');
}, /^TypeError: invalid arguments: callback must be passed$/);
assert.throws(function() {
dns.lookup('www.google.com', 4);
}, /^TypeError: invalid arguments: callback must be passed$/);
assert.doesNotThrow(function() {
dns.lookup('www.google.com', 6, noop);
});
assert.doesNotThrow(function() {
dns.lookup('www.google.com', {}, noop);
});
assert.doesNotThrow(function() {
dns.lookup('', {
family: 4,
hints: 0
}, noop);
});
assert.doesNotThrow(function() {
dns.lookup('', {
family: 6,
hints: dns.ADDRCONFIG
}, noop);
});
assert.doesNotThrow(function() {
dns.lookup('', {
hints: dns.V4MAPPED
}, noop);
});
assert.doesNotThrow(function() {
dns.lookup('', {
hints: dns.ADDRCONFIG | dns.V4MAPPED
}, noop);
});
assert.throws(function() {
dns.lookupService('0.0.0.0');
}, /^Error: invalid arguments$/);
assert.throws(function() {
dns.lookupService('fasdfdsaf', 0, noop);
}, /^TypeError: host needs to be a valid IP address$/);
assert.throws(function() {
dns.lookupService('0.0.0.0', '0', noop);
}, /^TypeError: port argument must be a number, got "0"$/);
assert.doesNotThrow(function() {
dns.lookupService('0.0.0.0', 0, noop);
});