gitroo-admin/node
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
node/lib
History
Exact
Сковорода Никита Андреевич f46952e727 buffer: safeguard against accidental kNoZeroFill 
This makes sure that `kNoZeroFill` flag is not accidentally set by
moving the all the flag operations directly inside `createBuffer()`.
It safeguards against logical errors like
https://github.com/nodejs/node/issues/6006.

This also ensures that `kNoZeroFill` flag is always restored to 0 using
a try-finally block, as it could be not restored to 0 in cases of failed
or zero-size `Uint8Array` allocation.
It safeguards against errors like
https://github.com/nodejs/node/issues/2930.
It also makes the `size > 0` check not needed there.

PR-URL: https://github.com/nodejs/node-private/pull/30
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
2016-05-04 10:34:19 -07:00
..
internal child_process: refactor self=this in socket_list 2016-04-08 17:34:18 -04:00
.eslintrc tools: apply custom buffer lint rule to /lib only 2016-03-21 12:57:59 -07:00
_debug_agent.js lib: refactor code with startsWith/endsWith 2016-04-08 17:16:43 -04:00
_debugger.js lib: refactor code with startsWith/endsWith 2016-04-08 17:16:43 -04:00
_http_agent.js https: fix ssl socket leak when keepalive is used 2016-03-30 13:12:15 -07:00
_http_client.js lib: copy arguments object instead of leaking it 2016-03-30 13:12:12 -07:00
_http_common.js http: remove reference to onParserExecute 2016-03-02 14:01:11 -08:00
_http_incoming.js http: remove old, confusing comment 2016-03-21 12:57:55 -07:00
_http_outgoing.js http: remove unnecessary check 2016-03-21 12:57:55 -07:00
_http_server.js http,util: fix typos in comments 2016-03-21 12:57:50 -07:00
_linklist.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
_stream_duplex.js node: allow multiple arguments passed to nextTick 2015-04-15 17:02:21 -06:00
_stream_passthrough.js lib: use const to define constants 2015-01-21 16:21:31 -05:00
_stream_readable.js stream: prevent object map change in ReadableState 2016-03-21 12:57:53 -07:00
_stream_transform.js stream: prevent object map change in TransformState 2016-03-21 12:57:54 -07:00
_stream_wrap.js stream_wrap: error if stream has StringDecoder 2015-12-23 08:38:33 -08:00
_stream_writable.js streams: support unlimited synchronous cork/uncork cycles 2016-05-04 10:19:04 -07:00
_tls_common.js tls: scope loop vars with let 2016-03-02 14:01:11 -08:00
_tls_legacy.js lib: use arrow functions instead of bind 2016-03-02 14:01:11 -08:00
_tls_wrap.js lib: copy arguments object instead of leaking it 2016-03-30 13:12:12 -07:00
assert.js assert: Check typed array view type in deepEqual 2016-04-11 12:38:56 -04:00
buffer.js buffer: safeguard against accidental kNoZeroFill 2016-05-04 10:34:19 -07:00
child_process.js child_process: add safety checks on stdio access 2015-12-23 08:38:33 -08:00
cluster.js lib: refactor code with startsWith/endsWith 2016-04-08 17:16:43 -04:00
console.js console: check that stderr is writable 2016-03-30 13:12:14 -07:00
constants.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
crypto.js streams: refactor LazyTransform to internal/ 2015-09-15 13:53:21 -04:00
dgram.js lib: reduce usage of self = this 2016-03-30 13:12:13 -07:00
dns.js dns: Use object without protoype for map 2016-04-08 17:23:45 -04:00
domain.js domains: fix handling of uncaught exceptions 2015-12-23 08:38:33 -08:00
events.js lib,test: remove extra semicolons 2016-03-02 14:01:11 -08:00
freelist.js lib,test: add freelist deprecation and test 2015-07-17 19:48:31 -07:00
fs.js fs: Remove unused branches 2016-04-08 16:42:49 -04:00
http.js lib,src: remove usage of events.EventEmitter 2015-09-23 08:39:34 +10:00
https.js lib: reduce usage of self = this 2016-03-30 13:12:13 -07:00
module.js module: refactor redeclared variable 2016-03-02 14:01:11 -08:00
net.js net: make isIPv4 and isIPv6 more efficient 2016-03-30 13:12:13 -07:00
os.js lib: refactor code with startsWith/endsWith 2016-04-08 17:16:43 -04:00
path.js lib: scope loop variables 2016-03-02 14:01:11 -08:00
process.js src: remove excessive license boilerplate 2015-01-27 16:35:05 +11:00
punycode.js lib: add missing new for errors lib/*.js 2015-03-24 12:42:15 -07:00
querystring.js querystring: don't stringify bad surrogate pair 2016-04-11 11:10:47 -04:00
readline.js lib: refactor code with startsWith/endsWith 2016-04-08 17:16:43 -04:00
repl.js lib: refactor code with startsWith/endsWith 2016-04-08 17:16:43 -04:00
stream.js lib,src: remove usage of events.EventEmitter 2015-09-23 08:39:34 +10:00
string_decoder.js string_decoder: fix performance regression 2016-03-21 12:57:54 -07:00
sys.js util: introduce printDeprecationMessage function 2015-06-04 10:59:43 +03:00
timers.js tools: add Node.js-specific ESLint rules 2016-03-21 12:57:57 -07:00
tls.js lib: refactor code with startsWith/endsWith 2016-04-08 17:16:43 -04:00
tty.js util: prepend '(node) ' to deprecation messages 2015-07-03 16:32:29 +02:00
url.js url: group slashed protocols by protocol name 2016-03-21 12:57:59 -07:00
util.js http,util: fix typos in comments 2016-03-21 12:57:50 -07:00
v8.js src: add total_available_size to v8 statistics 2015-08-11 22:51:50 +02:00
vm.js lib: reduce util.is*() usage 2015-01-31 23:47:29 -05:00
zlib.js zlib: only apply drain listener if given callback 2015-12-23 08:38:33 -08:00