d795301025
common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. The main tradeoff for this bit of code churn is that it gets the code base most of the way to being able to enable the no-unused-vars rule in eslint. (The non-tooling benefit is that it lessens cognitive load when reading tests as it is an immediate indication that none of the functions or properties in common.js will be used by the test.) PR-URL: https://github.com/nodejs/node/pull/4563 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
74 lines
1.8 KiB
JavaScript
74 lines
1.8 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
var assert = require('assert');
|
|
|
|
// verify that stdout is never read from.
|
|
var net = require('net');
|
|
var read = net.Socket.prototype.read;
|
|
|
|
net.Socket.prototype.read = function() {
|
|
if (this.fd === 1)
|
|
throw new Error('reading from stdout!');
|
|
if (this.fd === 2)
|
|
throw new Error('reading from stderr!');
|
|
return read.apply(this, arguments);
|
|
};
|
|
|
|
if (process.argv[2] === 'child')
|
|
child();
|
|
else
|
|
parent();
|
|
|
|
function parent() {
|
|
var spawn = require('child_process').spawn;
|
|
var node = process.execPath;
|
|
var closes = 0;
|
|
|
|
var c1 = spawn(node, [__filename, 'child']);
|
|
var c1out = '';
|
|
c1.stdout.setEncoding('utf8');
|
|
c1.stdout.on('data', function(chunk) {
|
|
c1out += chunk;
|
|
});
|
|
c1.stderr.setEncoding('utf8');
|
|
c1.stderr.on('data', function(chunk) {
|
|
console.error('c1err: ' + chunk.split('\n').join('\nc1err: '));
|
|
});
|
|
c1.on('close', function(code, signal) {
|
|
closes++;
|
|
assert(!code);
|
|
assert(!signal);
|
|
assert.equal(c1out, 'ok\n');
|
|
console.log('ok');
|
|
});
|
|
|
|
var c2 = spawn(node, ['-e', 'console.log("ok")']);
|
|
var c2out = '';
|
|
c2.stdout.setEncoding('utf8');
|
|
c2.stdout.on('data', function(chunk) {
|
|
c2out += chunk;
|
|
});
|
|
c1.stderr.setEncoding('utf8');
|
|
c1.stderr.on('data', function(chunk) {
|
|
console.error('c1err: ' + chunk.split('\n').join('\nc1err: '));
|
|
});
|
|
c2.on('close', function(code, signal) {
|
|
closes++;
|
|
assert(!code);
|
|
assert(!signal);
|
|
assert.equal(c2out, 'ok\n');
|
|
console.log('ok');
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.equal(closes, 2, 'saw both closes');
|
|
});
|
|
}
|
|
|
|
function child() {
|
|
// should not be reading *ever* in here.
|
|
net.Socket.prototype.read = function() {
|
|
throw new Error('no reading allowed in child');
|
|
};
|
|
console.log('ok');
|
|
}
|