d795301025
common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. The main tradeoff for this bit of code churn is that it gets the code base most of the way to being able to enable the no-unused-vars rule in eslint. (The non-tooling benefit is that it lessens cognitive load when reading tests as it is an immediate indication that none of the functions or properties in common.js will be used by the test.) PR-URL: https://github.com/nodejs/node/pull/4563 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
47 lines
1.1 KiB
JavaScript
47 lines
1.1 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
var assert = require('assert');
|
|
var domain = require('domain');
|
|
var disposalFailed = false;
|
|
|
|
// no matter what happens, we should increment a 10 times.
|
|
var a = 0;
|
|
log();
|
|
function log() {
|
|
console.log(a++, process.domain);
|
|
if (a < 10) setTimeout(log, 20);
|
|
}
|
|
|
|
// in 50ms we'll throw an error.
|
|
setTimeout(err, 50);
|
|
function err() {
|
|
var d = domain.create();
|
|
d.on('error', handle);
|
|
d.run(err2);
|
|
|
|
function err2() {
|
|
// this timeout should never be called, since the domain gets
|
|
// disposed when the error happens.
|
|
setTimeout(function() {
|
|
console.error('This should not happen.');
|
|
disposalFailed = true;
|
|
process.exit(1);
|
|
});
|
|
|
|
// this function doesn't exist, and throws an error as a result.
|
|
err3();
|
|
}
|
|
|
|
function handle(e) {
|
|
// this should clean up everything properly.
|
|
d.dispose();
|
|
console.error(e);
|
|
console.error('in handler', process.domain, process.domain === d);
|
|
}
|
|
}
|
|
|
|
process.on('exit', function() {
|
|
assert.equal(a, 10);
|
|
assert.equal(disposalFailed, false);
|
|
console.log('ok');
|
|
});
|