gitroo-admin/node
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
node/lib
History
Exact
Gareth Ellis 96e163a79f buffer: changing let in for loops back to var 
Using let in for loops showed a regression in 4.4.0. @ofrobots
suggested that we avoid using let in for loops until TurboFan becomes
the default optimiser.

The regression that was detected was when looking at how long it took
to create a new buffer from an array of data.

When using `for (let i=0; i<length; i++) ` we saw the operation take
almost 40% longer compared to `var i=0`.

PR-URL: https://github.com/nodejs/node/pull/5819
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Trevor Norris <trevnorris@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Ref: http://github.com/nodejs/benchmarking/issues/38
2016-03-30 13:12:17 -07:00
..
internal lib: freelist: use .pop() for allocation 2016-03-21 12:57:52 -07:00
.eslintrc tools: apply custom buffer lint rule to /lib only 2016-03-21 12:57:59 -07:00
_debug_agent.js debugger: assert test before accessing this.binding 2016-03-02 14:01:11 -08:00
_debugger.js lib: simplify code with String.prototype.repeat() 2016-03-30 13:12:13 -07:00
_http_agent.js https: fix ssl socket leak when keepalive is used 2016-03-30 13:12:15 -07:00
_http_client.js lib: copy arguments object instead of leaking it 2016-03-30 13:12:12 -07:00
_http_common.js http: remove reference to onParserExecute 2016-03-02 14:01:11 -08:00
_http_incoming.js http: remove old, confusing comment 2016-03-21 12:57:55 -07:00
_http_outgoing.js http: remove unnecessary check 2016-03-21 12:57:55 -07:00
_http_server.js http,util: fix typos in comments 2016-03-21 12:57:50 -07:00
_linklist.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
_stream_duplex.js node: allow multiple arguments passed to nextTick 2015-04-15 17:02:21 -06:00
_stream_passthrough.js lib: use const to define constants 2015-01-21 16:21:31 -05:00
_stream_readable.js stream: prevent object map change in ReadableState 2016-03-21 12:57:53 -07:00
_stream_transform.js stream: prevent object map change in TransformState 2016-03-21 12:57:54 -07:00
_stream_wrap.js stream_wrap: error if stream has StringDecoder 2015-12-23 08:38:33 -08:00
_stream_writable.js streams: 5% throughput gain when sending small chunks 2016-03-02 14:01:11 -08:00
_tls_common.js tls: scope loop vars with let 2016-03-02 14:01:11 -08:00
_tls_legacy.js lib: use arrow functions instead of bind 2016-03-02 14:01:11 -08:00
_tls_wrap.js lib: copy arguments object instead of leaking it 2016-03-30 13:12:12 -07:00
assert.js lib: copy arguments object instead of leaking it 2016-03-30 13:12:12 -07:00
buffer.js buffer: changing let in for loops back to var 2016-03-30 13:12:17 -07:00
child_process.js child_process: add safety checks on stdio access 2015-12-23 08:38:33 -08:00
cluster.js cluster: dont rely on this in fork 2016-03-02 14:01:11 -08:00
console.js console: check that stderr is writable 2016-03-30 13:12:14 -07:00
constants.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
crypto.js streams: refactor LazyTransform to internal/ 2015-09-15 13:53:21 -04:00
dgram.js lib: reduce usage of self = this 2016-03-30 13:12:13 -07:00
dns.js dns: use template literals 2016-03-30 13:12:16 -07:00
domain.js domains: fix handling of uncaught exceptions 2015-12-23 08:38:33 -08:00
events.js lib,test: remove extra semicolons 2016-03-02 14:01:11 -08:00
freelist.js lib,test: add freelist deprecation and test 2015-07-17 19:48:31 -07:00
fs.js fs: refactor redeclared variables 2016-03-02 14:01:11 -08:00
http.js lib,src: remove usage of events.EventEmitter 2015-09-23 08:39:34 +10:00
https.js lib: reduce usage of self = this 2016-03-30 13:12:13 -07:00
module.js module: refactor redeclared variable 2016-03-02 14:01:11 -08:00
net.js net: make isIPv4 and isIPv6 more efficient 2016-03-30 13:12:13 -07:00
os.js lib: remove unused modules 2016-01-19 11:52:39 -08:00
path.js lib: scope loop variables 2016-03-02 14:01:11 -08:00
process.js src: remove excessive license boilerplate 2015-01-27 16:35:05 +11:00
punycode.js lib: add missing new for errors lib/*.js 2015-03-24 12:42:15 -07:00
querystring.js querystring: improve parse() performance 2016-03-02 14:01:11 -08:00
readline.js readline: Remove XXX and output debuglog 2016-02-15 11:30:23 -08:00
repl.js repl: fix stack trace column number in strict mode 2016-03-30 13:12:13 -07:00
stream.js lib,src: remove usage of events.EventEmitter 2015-09-23 08:39:34 +10:00
string_decoder.js string_decoder: fix performance regression 2016-03-21 12:57:54 -07:00
sys.js util: introduce printDeprecationMessage function 2015-06-04 10:59:43 +03:00
timers.js tools: add Node.js-specific ESLint rules 2016-03-21 12:57:57 -07:00
tls.js lib: fix style issues after eslint update 2016-02-15 11:30:23 -08:00
tty.js util: prepend '(node) ' to deprecation messages 2015-07-03 16:32:29 +02:00
url.js url: group slashed protocols by protocol name 2016-03-21 12:57:59 -07:00
util.js http,util: fix typos in comments 2016-03-21 12:57:50 -07:00
v8.js src: add total_available_size to v8 statistics 2015-08-11 22:51:50 +02:00
vm.js lib: reduce util.is*() usage 2015-01-31 23:47:29 -05:00
zlib.js zlib: only apply drain listener if given callback 2015-12-23 08:38:33 -08:00