gitroo-admin/node
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
node/test/fixtures
History
Exact
Myles Borins 1b070e48e0 node_contextify: do not incept debug context 
Currently a debug context is created for various calls to util.

If the node debugger is being run the main context is the debug
context. In this case node_contextify was freeing the debug context
and causing everything to explode.

This change moves around the logic and no longer frees the context.

There is a concern about the dangling pointer

The regression test was adapted from code submitted by @3y3 in #4815

Fixes: https://github.com/nodejs/node/issues/4440
Fixes: https://github.com/nodejs/node/issues/4815
Fixes: https://github.com/nodejs/node/issues/4597
Fixes: https://github.com/nodejs/node/issues/4952

PR-URL: https://github.com/nodejs/node/issues/4815

Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2016-02-15 11:30:23 -08:00
..
b Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
break-in-module Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
clustered-server test: common.js -> common 2015-02-22 19:34:17 -08:00
cycles Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
empty
global Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
internal-modules iojs: introduce internal modules 2015-03-25 22:12:18 +03:00
json-with-directory-name-module Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
keys crypto: load PFX chain the same way as regular one 2016-01-19 11:52:31 -08:00
module-load-order Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
module-require module: allow require('.') 2015-03-20 18:17:25 +01:00
nested-index Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
node_modules repl: fix require('3rdparty') regression 2016-01-19 11:52:30 -08:00
packages Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
require-bin module: fix regression in require ../ 2014-12-11 10:18:00 +01:00
syntax src: wrap source before doing syntax check 2015-10-29 12:40:23 -07:00
test-init-index Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
test-init-native Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
uncaught-exceptions src: break on uncaught exception 2013-06-26 19:54:31 +02:00
.empty-repl-history-file repl: Fixed node repl history edge case. 2016-01-19 11:52:31 -08:00
.node_repl_history test: add tests for persistent repl history 2015-08-04 11:56:18 -07:00
a.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
a1.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
agent.crt
agent.key
alice.crt
breakpoints.js
breakpoints_utf8.js
catch-stdout-error.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
cert.pem
child-process-message-and-exit.js
child-process-persistent.js test: enable linting for tests 2015-05-19 21:21:27 +02:00
child-process-spawn-node.js
child_process_should_emit_error.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
cluster-preload-test.js src: setup cluster workers before preloading 2015-04-04 00:53:45 +02:00
cluster-preload.js node: rename from io.js to node 2015-08-23 17:59:43 -04:00
create-file.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
debug-target.js
debugger-util-regression-fixture.js node_contextify: do not incept debug context 2016-02-15 11:30:23 -08:00
deprecated-userland-function.js util: prepend '(node) ' to deprecation messages 2015-07-03 16:32:29 +02:00
deprecated.js
destroy-stdin.js
dherror.pem tls, crypto: add DHE support 2014-08-29 00:36:48 +04:00
echo-close-check.js win,test: fix test-stdin-from-file 2015-03-05 15:30:52 +01:00
echo.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
elipses.txt
empty.js
empty.txt
exit.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
exports-function-with-param.js test: add test for debugging one line files 2016-01-20 17:06:07 -08:00
fixture.ini
foafssl.crt
foafssl.key
foo
GH-892-request.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
GH-1899-output.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
invalid.json
listen-on-socket-and-exit.js test: only refresh tmpDir for tests that need it 2015-06-13 22:27:17 -07:00
module-loading-error.node
msca.pem
multi-alice.crt
net-fd-passing-receiver.js test: change calls to deprecated util.print() 2015-09-30 22:19:52 +10:00
not-main-module.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
old-repl-history-file.json test: add tests for persistent repl history 2015-08-04 11:56:18 -07:00
parent-process-nonpersistent.js
pass-cert.pem
pass-csr.pem
pass-key.pem test: stronger crypto in test fixtures 2015-12-23 08:38:33 -08:00
path.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
person.jpg
person.jpg.gz
print-10-lines.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
print-chars-from-buffer.js test: create temp dir in common.js 2015-06-12 10:27:29 +10:00
print-chars.js test: create temp dir in common.js 2015-06-12 10:27:29 +10:00
printA.js src: add -r/--require flags for preloading modules 2015-03-19 21:42:16 +11:00
printB.js src: add -r/--require flags for preloading modules 2015-03-19 21:42:16 +11:00
printC.js src: add -r/--require flags for preloading modules 2015-03-19 21:42:16 +11:00
recvfd.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
registerExt.hello.world
registerExt.test
registerExt2.test
sample.png
semicolon.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
should_exit.js test: fix timing issue in signal test 2015-03-23 00:55:34 +01:00
spkac.fail crypto: add SPKAC support 2013-10-16 09:43:19 -07:00
spkac.pem crypto: add SPKAC support 2013-10-16 09:43:19 -07:00
spkac.valid crypto: add SPKAC support 2013-10-16 09:43:19 -07:00
stdio-filter.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
test-error-first-line-offset.js module: fix column offsets in errors 2016-01-19 11:52:10 -08:00
test-fs-readfile-error.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
test-regress-GH-4015.js
test_bad_rsa_privkey.pem crypto: check for OpenSSL errors when signing 2015-08-17 21:38:12 -07:00
test_ca.pem
test_cert.pem
test_cert.pfx test: stronger crypto in test fixtures 2015-12-23 08:38:33 -08:00
test_dsa_params.pem
test_dsa_privkey.pem test: stronger crypto in test fixtures 2015-12-23 08:38:33 -08:00
test_dsa_privkey_encrypted.pem test: stronger crypto in test fixtures 2015-12-23 08:38:33 -08:00
test_dsa_pubkey.pem test: stronger crypto in test fixtures 2015-12-23 08:38:33 -08:00
test_key.pem
test_rsa_privkey.pem
test_rsa_privkey_2.pem
test_rsa_privkey_encrypted.pem test: stronger crypto in test fixtures 2015-12-23 08:38:33 -08:00
test_rsa_pubkey.pem
test_rsa_pubkey_2.pem
throws_error.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
throws_error1.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
throws_error2.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
throws_error3.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
throws_error4.js Remove excessive copyright/license boilerplate 2015-01-12 15:30:28 -08:00
throws_error5.js src: fix buffer overflow for long exception lines 2015-09-06 21:39:07 +10:00
throws_error6.js src: use standard conform snprintf on windows 2015-09-06 21:39:07 +10:00
throws_error7.js src: don't print garbage errors 2016-01-19 11:52:17 -08:00
tls-session-ticket.txt
utf8-bom.js
utf8-bom.json
vm-run-in-debug-context.js vm: fix crash on fatal error in debug context 2015-03-22 20:07:49 +01:00
x.txt
x1024.txt