d795301025
common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. The main tradeoff for this bit of code churn is that it gets the code base most of the way to being able to enable the no-unused-vars rule in eslint. (The non-tooling benefit is that it lessens cognitive load when reading tests as it is an immediate indication that none of the functions or properties in common.js will be used by the test.) PR-URL: https://github.com/nodejs/node/pull/4563 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
147 lines
3.3 KiB
JavaScript
147 lines
3.3 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
var assert = require('assert');
|
|
|
|
var dns = require('dns');
|
|
|
|
var existing = dns.getServers();
|
|
assert(existing.length);
|
|
|
|
function noop() {}
|
|
|
|
var goog = [
|
|
'8.8.8.8',
|
|
'8.8.4.4',
|
|
];
|
|
assert.doesNotThrow(function() { dns.setServers(goog); });
|
|
assert.deepEqual(dns.getServers(), goog);
|
|
assert.throws(function() { dns.setServers(['foobar']); });
|
|
assert.deepEqual(dns.getServers(), goog);
|
|
|
|
var goog6 = [
|
|
'2001:4860:4860::8888',
|
|
'2001:4860:4860::8844',
|
|
];
|
|
assert.doesNotThrow(function() { dns.setServers(goog6); });
|
|
assert.deepEqual(dns.getServers(), goog6);
|
|
|
|
goog6.push('4.4.4.4');
|
|
dns.setServers(goog6);
|
|
assert.deepEqual(dns.getServers(), goog6);
|
|
|
|
var ports = [
|
|
'4.4.4.4:53',
|
|
'[2001:4860:4860::8888]:53',
|
|
];
|
|
var portsExpected = [
|
|
'4.4.4.4',
|
|
'2001:4860:4860::8888',
|
|
];
|
|
dns.setServers(ports);
|
|
assert.deepEqual(dns.getServers(), portsExpected);
|
|
|
|
assert.doesNotThrow(function() { dns.setServers([]); });
|
|
assert.deepEqual(dns.getServers(), []);
|
|
|
|
assert.throws(function() {
|
|
dns.resolve('test.com', [], noop);
|
|
}, function(err) {
|
|
return !(err instanceof TypeError);
|
|
}, 'Unexpected error');
|
|
|
|
// dns.lookup should accept falsey and string values
|
|
assert.throws(function() {
|
|
dns.lookup({}, noop);
|
|
}, 'invalid arguments: hostname must be a string or falsey');
|
|
|
|
assert.throws(function() {
|
|
dns.lookup([], noop);
|
|
}, 'invalid arguments: hostname must be a string or falsey');
|
|
|
|
assert.throws(function() {
|
|
dns.lookup(true, noop);
|
|
}, 'invalid arguments: hostname must be a string or falsey');
|
|
|
|
assert.throws(function() {
|
|
dns.lookup(1, noop);
|
|
}, 'invalid arguments: hostname must be a string or falsey');
|
|
|
|
assert.throws(function() {
|
|
dns.lookup(noop, noop);
|
|
}, 'invalid arguments: hostname must be a string or falsey');
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup('', noop);
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup(null, noop);
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup(undefined, noop);
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup(0, noop);
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup(NaN, noop);
|
|
});
|
|
|
|
/*
|
|
* Make sure that dns.lookup throws if hints does not represent a valid flag.
|
|
* (dns.V4MAPPED | dns.ADDRCONFIG) + 1 is invalid because:
|
|
* - it's different from dns.V4MAPPED and dns.ADDRCONFIG.
|
|
* - it's different from them bitwise ored.
|
|
* - it's different from 0.
|
|
* - it's an odd number different than 1, and thus is invalid, because
|
|
* flags are either === 1 or even.
|
|
*/
|
|
assert.throws(function() {
|
|
dns.lookup('www.google.com', { hints: (dns.V4MAPPED | dns.ADDRCONFIG) + 1 },
|
|
noop);
|
|
});
|
|
|
|
assert.throws(function() {
|
|
dns.lookup('www.google.com');
|
|
}, 'invalid arguments: callback must be passed');
|
|
|
|
assert.throws(function() {
|
|
dns.lookup('www.google.com', 4);
|
|
}, 'invalid arguments: callback must be passed');
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup('www.google.com', 6, noop);
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup('www.google.com', {}, noop);
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup('www.google.com', {
|
|
family: 4,
|
|
hints: 0
|
|
}, noop);
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup('www.google.com', {
|
|
family: 6,
|
|
hints: dns.ADDRCONFIG
|
|
}, noop);
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup('www.google.com', {
|
|
hints: dns.V4MAPPED
|
|
}, noop);
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
dns.lookup('www.google.com', {
|
|
hints: dns.ADDRCONFIG | dns.V4MAPPED
|
|
}, noop);
|
|
});
|