d795301025
common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. The main tradeoff for this bit of code churn is that it gets the code base most of the way to being able to enable the no-unused-vars rule in eslint. (The non-tooling benefit is that it lessens cognitive load when reading tests as it is an immediate indication that none of the functions or properties in common.js will be used by the test.) PR-URL: https://github.com/nodejs/node/pull/4563 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
45 lines
1.2 KiB
JavaScript
45 lines
1.2 KiB
JavaScript
'use strict';
|
|
// test uncompressing invalid input
|
|
|
|
require('../common');
|
|
var assert = require('assert'),
|
|
zlib = require('zlib');
|
|
|
|
var nonStringInputs = [1, true, {a: 1}, ['a']];
|
|
|
|
console.error('Doing the non-strings');
|
|
nonStringInputs.forEach(function(input) {
|
|
// zlib.gunzip should not throw an error when called with bad input.
|
|
assert.doesNotThrow(function() {
|
|
zlib.gunzip(input, function(err, buffer) {
|
|
// zlib.gunzip should pass the error to the callback.
|
|
assert.ok(err);
|
|
});
|
|
});
|
|
});
|
|
|
|
console.error('Doing the unzips');
|
|
// zlib.Unzip classes need to get valid data, or else they'll throw.
|
|
var unzips = [ zlib.Unzip(),
|
|
zlib.Gunzip(),
|
|
zlib.Inflate(),
|
|
zlib.InflateRaw() ];
|
|
var hadError = [];
|
|
unzips.forEach(function(uz, i) {
|
|
console.error('Error for ' + uz.constructor.name);
|
|
uz.on('error', function(er) {
|
|
console.error('Error event', er);
|
|
hadError[i] = true;
|
|
});
|
|
|
|
uz.on('end', function(er) {
|
|
throw new Error('end event should not be emitted ' + uz.constructor.name);
|
|
});
|
|
|
|
// this will trigger error event
|
|
uz.write('this is not valid compressed data.');
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.deepEqual(hadError, [true, true, true, true], 'expect 4 errors');
|
|
});
|