common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. The main tradeoff for this bit of code churn is that it gets the code base most of the way to being able to enable the no-unused-vars rule in eslint. (The non-tooling benefit is that it lessens cognitive load when reading tests as it is an immediate indication that none of the functions or properties in common.js will be used by the test.) PR-URL: https://github.com/nodejs/node/pull/4563 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
42 lines
1.2 KiB
JavaScript
42 lines
1.2 KiB
JavaScript
'use strict';
|
|
// Flags: --expose_internals
|
|
|
|
require('../common');
|
|
var assert = require('assert');
|
|
var _validateStdio = require('internal/child_process')._validateStdio;
|
|
|
|
// should throw if string and not ignore, pipe, or inherit
|
|
assert.throws(function() {
|
|
_validateStdio('foo');
|
|
}, /Incorrect value of stdio option/);
|
|
|
|
// should throw if not a string or array
|
|
assert.throws(function() {
|
|
_validateStdio(600);
|
|
}, /Incorrect value of stdio option/);
|
|
|
|
// should populate stdio with undefined if len < 3
|
|
var stdio1 = [];
|
|
var result = _validateStdio(stdio1, false);
|
|
assert.equal(stdio1.length, 3);
|
|
assert.equal(result.hasOwnProperty('stdio'), true);
|
|
assert.equal(result.hasOwnProperty('ipc'), true);
|
|
assert.equal(result.hasOwnProperty('ipcFd'), true);
|
|
|
|
// should throw if stdio has ipc and sync is true
|
|
var stdio2 = ['ipc', 'ipc', 'ipc'];
|
|
assert.throws(function() {
|
|
_validateStdio(stdio2, true);
|
|
}, /You cannot use IPC with synchronous forks/);
|
|
|
|
const stdio3 = [process.stdin, process.stdout, process.stderr];
|
|
var result = _validateStdio(stdio3, false);
|
|
assert.deepStrictEqual(result, {
|
|
stdio: [
|
|
{ type: 'fd', fd: 0 },
|
|
{ type: 'fd', fd: 1 },
|
|
{ type: 'fd', fd: 2 }
|
|
],
|
|
ipc: undefined,
|
|
ipcFd: undefined
|
|
});
|