c245a199a7
63644dd1cd introduced a regression caused by everyone's favourite
JavaScript feature: undefined < 0 === undefined >= 0.
Add a case to the existing tests to cover this scenario and then add
the check for undefined that makes the test pass.
PR-URL: https://github.com/nodejs/node/pull/3331
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed By: Evan Lucas <evanlucas@me.com>
34 lines
870 B
JavaScript
34 lines
870 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const active = require('timers').active;
|
|
|
|
// active() should create timers for these
|
|
var legitTimers = [
|
|
{ _idleTimeout: 0 },
|
|
{ _idleTimeout: 1 }
|
|
];
|
|
|
|
legitTimers.forEach(function(legit) {
|
|
const savedTimeout = legit._idleTimeout;
|
|
active(legit);
|
|
// active() should mutate these objects
|
|
assert(legit._idleTimeout === savedTimeout);
|
|
assert(Number.isInteger(legit._idleStart));
|
|
assert(legit._idleNext);
|
|
assert(legit._idlePrev);
|
|
});
|
|
|
|
|
|
// active() should not create a timer for these
|
|
var bogusTimers = [
|
|
{ _idleTimeout: -1 },
|
|
{ _idleTimeout: undefined },
|
|
];
|
|
|
|
bogusTimers.forEach(function(bogus) {
|
|
const savedTimeout = bogus._idleTimeout;
|
|
active(bogus);
|
|
// active() should not mutate these objects
|
|
assert.deepStrictEqual(bogus, {_idleTimeout: savedTimeout});
|
|
});
|