9cd44bb2b6
Changes included in this commit are
1. Making the deprecation messages consistent. The messages will be in
the following format
x is deprecated. Use y instead.
If there is no alternative for `x`, then the ` Use y instead.` part
will not be there in the message.
2. All the internal deprecation messages are printed with the prefix
`(node) `, except when the `--trace-deprecation` flag is set.
Fixes: https://github.com/nodejs/io.js/issues/1883
PR-URL: https://github.com/nodejs/io.js/pull/1892
Reviewed-By: Roman Reiss <me@silverwind.io>
50 lines
1.7 KiB
JavaScript
50 lines
1.7 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var execFile = require('child_process').execFile;
|
|
var depmod = require.resolve('../fixtures/deprecated.js');
|
|
var node = process.execPath;
|
|
|
|
var depUserland =
|
|
require.resolve('../fixtures/deprecated-userland-function.js');
|
|
|
|
var normal = [depmod];
|
|
var noDep = ['--no-deprecation', depmod];
|
|
var traceDep = ['--trace-deprecation', depmod];
|
|
|
|
execFile(node, normal, function(er, stdout, stderr) {
|
|
console.error('normal: show deprecation warning');
|
|
assert.equal(er, null);
|
|
assert.equal(stdout, '');
|
|
assert.equal(stderr, '(node) util.p is deprecated. Use console.error ' +
|
|
'instead.\n\'This is deprecated\'\n');
|
|
console.log('normal ok');
|
|
});
|
|
|
|
execFile(node, noDep, function(er, stdout, stderr) {
|
|
console.error('--no-deprecation: silence deprecations');
|
|
assert.equal(er, null);
|
|
assert.equal(stdout, '');
|
|
assert.equal(stderr, '\'This is deprecated\'\n');
|
|
console.log('silent ok');
|
|
});
|
|
|
|
execFile(node, traceDep, function(er, stdout, stderr) {
|
|
console.error('--trace-deprecation: show stack');
|
|
assert.equal(er, null);
|
|
assert.equal(stdout, '');
|
|
var stack = stderr.trim().split('\n');
|
|
// just check the top and bottom.
|
|
assert.equal(stack[0],
|
|
'Trace: util.p is deprecated. Use console.error instead.');
|
|
assert.equal(stack.pop(), '\'This is deprecated\'');
|
|
console.log('trace ok');
|
|
});
|
|
|
|
execFile(node, [depUserland], function(er, stdout, stderr) {
|
|
console.error('normal: testing deprecated userland function');
|
|
assert.equal(er, null);
|
|
assert.equal(stdout, '');
|
|
assert.equal(0, stderr.indexOf('deprecatedFunction is deprecated.'));
|
|
console.error('normal: ok');
|
|
});
|