dbc78ff825On slow CI, the outer Debugger.resume can be picked up in the same drain pass as the Debugger.evaluateOnCallFrame, while V8 still considers the context paused. In this case both resume calls may succeed and the process can continue running from the setInterval until the timeout. Accept both probe failure and timeout as valid to accommodate this flakiness. This patch also adds more debug logs to the probe mode to show more information in case it flakes again in the CI Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63524 Fixes: https://github.com/nodejs/node/issues/63505 Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
85 lines
3 KiB
JavaScript
85 lines
3 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('assert');
|
|
|
|
// Work around a pre-existing inspector issue: if the debuggee exits too quickly
|
|
// the inspector can segfault while tearing down. For now normalize the segfault
|
|
// back to the expected terminal event (e.g. "completed" or "miss")
|
|
// until the upstream bug is fixed.
|
|
// See https://github.com/nodejs/node/issues/62765
|
|
// https://github.com/nodejs/node/issues/58245
|
|
const probeTargetExitSignal = 'SIGSEGV';
|
|
|
|
function isProbeSegvTeardown(result) {
|
|
if (result?.event !== 'error') { return false; }
|
|
const error = result.error;
|
|
if (error?.signal !== probeTargetExitSignal) { return false; }
|
|
return error.code === 'probe_target_exit' || error.code === 'probe_failure';
|
|
}
|
|
|
|
function findProbeSegvTeardownLine(output) {
|
|
const signalPrefix = `Target exited with signal ${probeTargetExitSignal}`;
|
|
if (output.startsWith(signalPrefix)) { return 0; }
|
|
const idx = output.indexOf(`\n${signalPrefix}`);
|
|
return idx === -1 ? -1 : idx + 1;
|
|
}
|
|
|
|
// Replace volatile fields in a probe report (stack frames, Node.js version,
|
|
// scriptId, callFrames) with stable placeholders for deepStrictEqual.
|
|
function normalizeProbeReport(value) {
|
|
if (typeof value === 'string') {
|
|
return value
|
|
.replace(/(?:\n[ \t]+at\s[^\n]*)+/g, '\n<stack>')
|
|
.replace(/\nNode\.js v[^\n]+/g, '\nNode.js <version>');
|
|
}
|
|
if (Array.isArray(value)) {
|
|
return value.map(normalizeProbeReport);
|
|
}
|
|
if (value !== null && typeof value === 'object') {
|
|
const result = {};
|
|
for (const key of Object.keys(value)) {
|
|
if (key === 'scriptId') {
|
|
result[key] = '<scriptId>';
|
|
} else if (key === 'callFrames') {
|
|
result[key] = '<callFrames>';
|
|
} else {
|
|
result[key] = normalizeProbeReport(value[key]);
|
|
}
|
|
}
|
|
return result;
|
|
}
|
|
return value;
|
|
}
|
|
|
|
function assertProbeJson(output, expected) {
|
|
const normalized = typeof output === 'string' ? JSON.parse(output) : output;
|
|
const lastResult = normalized.results?.[normalized.results.length - 1];
|
|
|
|
if (isProbeSegvTeardown(lastResult)) {
|
|
// Log to facilitate debugging if this normalization is occurring.
|
|
console.log('Normalizing trailing SIGSEGV in JSON probe output');
|
|
normalized.results[normalized.results.length - 1] = expected.results.at(-1);
|
|
}
|
|
|
|
assert.deepStrictEqual(normalizeProbeReport(normalized), normalizeProbeReport(expected));
|
|
}
|
|
|
|
function assertProbeText(output, expected) {
|
|
const lineStart = findProbeSegvTeardownLine(output);
|
|
let normalized;
|
|
if (lineStart !== -1) {
|
|
// Log to facilitate debugging if this normalization is occurring.
|
|
console.log('Normalizing trailing SIGSEGV in text probe output');
|
|
const expectedLineStart = expected.lastIndexOf('\n');
|
|
const terminalLine = expectedLineStart === -1 ? expected : expected.slice(expectedLineStart + 1);
|
|
normalized = lineStart === 0 ? terminalLine : `${output.slice(0, lineStart - 1)}\n${terminalLine}`;
|
|
} else {
|
|
normalized = output;
|
|
}
|
|
assert.strictEqual(normalized, expected);
|
|
}
|
|
|
|
module.exports = {
|
|
assertProbeJson,
|
|
assertProbeText,
|
|
};
|