1fca8baac1In order to adapt to V8 changes regarding storing private properties on Externals, ExternalWrapper objects were introduced in #51149. However, this new code stores the type tag pointer and not the 128-bit value inside. This breaks some pre-existing code that were making temporary tags. It also means that unloading the module will cause existing External objects to have a tag pointer that points nowhere (use-after-free bug). Change ExternalWrapper to store tags by value to fix this regression. PR-URL: https://github.com/nodejs/node/pull/52426 Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> |
||
|---|---|---|
| .. | ||
| 2_function_arguments | ||
| 3_callbacks | ||
| 4_object_factory | ||
| 5_function_factory | ||
| 6_object_wrap | ||
| 7_factory_wrap | ||
| 8_passing_wrapped | ||
| test_array | ||
| test_bigint | ||
| test_cannot_run_js | ||
| test_constructor | ||
| test_conversions | ||
| test_dataview | ||
| test_date | ||
| test_error | ||
| test_exception | ||
| test_finalizer | ||
| test_function | ||
| test_general | ||
| test_handle_scope | ||
| test_instance_data | ||
| test_new_target | ||
| test_number | ||
| test_object | ||
| test_promise | ||
| test_properties | ||
| test_reference | ||
| test_reference_double_free | ||
| test_string | ||
| test_symbol | ||
| test_typedarray | ||
| .gitignore | ||
| common-inl.h | ||
| common.h | ||
| entry_point.h | ||
| testcfg.py | ||