a7d74633f2
tls.connect(options) with no options.host should accept a certificate with CN: 'localhost'. Fix Error: Hostname/IP doesn't match certificate's altnames: "Host: undefined. is not cert's CN: localhost" 'localhost' is not added directly to defaults because that is not always desired (for example, when using options.socket) PR-URL: https://github.com/iojs/io.js/pull/1493 Fixes: https://github.com/iojs/io.js/issues/1489 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Roman Reiss <me@silverwind.io>
34 lines
971 B
JavaScript
34 lines
971 B
JavaScript
var common = require('../common');
|
|
|
|
if (!common.hasCrypto) {
|
|
console.log('1..0 # Skipped: missing crypto');
|
|
process.exit();
|
|
}
|
|
var tls = require('tls');
|
|
|
|
var assert = require('assert');
|
|
var fs = require('fs');
|
|
var path = require('path');
|
|
|
|
var cert = fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'));
|
|
var key = fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem'));
|
|
|
|
// https://github.com/iojs/io.js/issues/1489
|
|
// tls.connect(options) with no options.host should accept a cert with
|
|
// CN:'localhost'
|
|
tls.createServer({
|
|
key: key,
|
|
cert: cert
|
|
}).listen(common.PORT);
|
|
|
|
var socket = tls.connect({
|
|
port: common.PORT,
|
|
ca: cert,
|
|
// No host set here. 'localhost' is the default,
|
|
// but tls.checkServerIdentity() breaks before the fix with:
|
|
// Error: Hostname/IP doesn't match certificate's altnames:
|
|
// "Host: undefined. is not cert's CN: localhost"
|
|
}, function() {
|
|
assert(socket.authorized);
|
|
process.exit();
|
|
});
|