23fc205586Comparing any value to any non-RegExp literal or undefined using
strictEqual (or notStrictEqual) passes if and only if deepStrictEqual
(or notDeepStrictEqual, respectively) passes.
Unnecessarily using deep comparisons adds confusion.
This patch adds an ESLint rule that forbids the use of deepStrictEqual
and notDeepStrictEqual when the expected value (i.e., the second
argument) is a non-RegExp literal or undefined.
For reference, an ESTree literal is defined as follows.
extend interface Literal <: Expression {
type: "Literal";
value: string | boolean | null | number | RegExp | bigint;
}
The value `undefined` is an `Identifier` with `name: 'undefined'`.
PR-URL: https://github.com/nodejs/node/pull/40634
Backport-PR-URL: https://github.com/nodejs/node/pull/42021
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
93 lines
2.5 KiB
JavaScript
93 lines
2.5 KiB
JavaScript
'use strict';
|
|
|
|
// This test makes sure that `writeFile()` always writes from the current
|
|
// position of the file, instead of truncating the file, when used with file
|
|
// descriptors.
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const join = require('path').join;
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
|
|
{
|
|
/* writeFileSync() test. */
|
|
const filename = join(tmpdir.path, 'test.txt');
|
|
|
|
/* Open the file descriptor. */
|
|
const fd = fs.openSync(filename, 'w');
|
|
try {
|
|
/* Write only five characters, so that the position moves to five. */
|
|
assert.strictEqual(fs.writeSync(fd, 'Hello'), 5);
|
|
assert.strictEqual(fs.readFileSync(filename).toString(), 'Hello');
|
|
|
|
/* Write some more with writeFileSync(). */
|
|
fs.writeFileSync(fd, 'World');
|
|
|
|
/* New content should be written at position five, instead of zero. */
|
|
assert.strictEqual(fs.readFileSync(filename).toString(), 'HelloWorld');
|
|
} finally {
|
|
fs.closeSync(fd);
|
|
}
|
|
}
|
|
|
|
const fdsToCloseOnExit = [];
|
|
process.on('beforeExit', common.mustCall(() => {
|
|
for (const fd of fdsToCloseOnExit) {
|
|
try {
|
|
fs.closeSync(fd);
|
|
} catch {
|
|
// Failed to close, ignore
|
|
}
|
|
}
|
|
}));
|
|
|
|
{
|
|
/* writeFile() test. */
|
|
const file = join(tmpdir.path, 'test1.txt');
|
|
|
|
/* Open the file descriptor. */
|
|
fs.open(file, 'w', common.mustSucceed((fd) => {
|
|
fdsToCloseOnExit.push(fd);
|
|
/* Write only five characters, so that the position moves to five. */
|
|
fs.write(fd, 'Hello', common.mustSucceed((bytes) => {
|
|
assert.strictEqual(bytes, 5);
|
|
assert.strictEqual(fs.readFileSync(file).toString(), 'Hello');
|
|
|
|
/* Write some more with writeFile(). */
|
|
fs.writeFile(fd, 'World', common.mustSucceed(() => {
|
|
/* New content should be written at position five, instead of zero. */
|
|
assert.strictEqual(fs.readFileSync(file).toString(), 'HelloWorld');
|
|
}));
|
|
}));
|
|
}));
|
|
}
|
|
|
|
|
|
// Test read-only file descriptor
|
|
{
|
|
const file = join(tmpdir.path, 'test.txt');
|
|
|
|
fs.open(file, 'r', common.mustSucceed((fd) => {
|
|
fdsToCloseOnExit.push(fd);
|
|
fs.writeFile(fd, 'World', common.expectsError(/EBADF/));
|
|
}));
|
|
}
|
|
|
|
// Test with an AbortSignal
|
|
{
|
|
const controller = new AbortController();
|
|
const signal = controller.signal;
|
|
const file = join(tmpdir.path, 'test.txt');
|
|
|
|
fs.open(file, 'w', common.mustSucceed((fd) => {
|
|
fdsToCloseOnExit.push(fd);
|
|
fs.writeFile(fd, 'World', { signal }, common.expectsError({
|
|
name: 'AbortError'
|
|
}));
|
|
}));
|
|
|
|
controller.abort();
|
|
}
|