23fc205586Comparing any value to any non-RegExp literal or undefined using
strictEqual (or notStrictEqual) passes if and only if deepStrictEqual
(or notDeepStrictEqual, respectively) passes.
Unnecessarily using deep comparisons adds confusion.
This patch adds an ESLint rule that forbids the use of deepStrictEqual
and notDeepStrictEqual when the expected value (i.e., the second
argument) is a non-RegExp literal or undefined.
For reference, an ESTree literal is defined as follows.
extend interface Literal <: Expression {
type: "Literal";
value: string | boolean | null | number | RegExp | bigint;
}
The value `undefined` is an `Identifier` with `name: 'undefined'`.
PR-URL: https://github.com/nodejs/node/pull/40634
Backport-PR-URL: https://github.com/nodejs/node/pull/42021
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
66 lines
2.3 KiB
JavaScript
66 lines
2.3 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs').promises;
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
tmpdir.refresh();
|
|
|
|
const expected = 'ümlaut. Лорем 運務ホソモ指及 आपको करने विकास 紙読決多密所 أضف';
|
|
const exptectedBuff = Buffer.from(expected);
|
|
|
|
let cnt = 0;
|
|
function getFileName() {
|
|
return path.join(tmpdir.path, `readv_promises_${++cnt}.txt`);
|
|
}
|
|
|
|
const allocateEmptyBuffers = (combinedLength) => {
|
|
const bufferArr = [];
|
|
// Allocate two buffers, each half the size of exptectedBuff
|
|
bufferArr[0] = Buffer.alloc(Math.floor(combinedLength / 2));
|
|
bufferArr[1] = Buffer.alloc(combinedLength - bufferArr[0].length);
|
|
|
|
return bufferArr;
|
|
};
|
|
|
|
(async () => {
|
|
{
|
|
const filename = getFileName();
|
|
await fs.writeFile(filename, exptectedBuff);
|
|
const handle = await fs.open(filename, 'r');
|
|
// const buffer = Buffer.from(expected);
|
|
const bufferArr = allocateEmptyBuffers(exptectedBuff.length);
|
|
const expectedLength = exptectedBuff.length;
|
|
|
|
let { bytesRead, buffers } = await handle.readv([Buffer.from('')],
|
|
null);
|
|
assert.strictEqual(bytesRead, 0);
|
|
assert.deepStrictEqual(buffers, [Buffer.from('')]);
|
|
|
|
({ bytesRead, buffers } = await handle.readv(bufferArr, null));
|
|
assert.strictEqual(bytesRead, expectedLength);
|
|
assert.deepStrictEqual(buffers, bufferArr);
|
|
assert(Buffer.concat(bufferArr).equals(await fs.readFile(filename)));
|
|
handle.close();
|
|
}
|
|
|
|
{
|
|
const filename = getFileName();
|
|
await fs.writeFile(filename, exptectedBuff);
|
|
const handle = await fs.open(filename, 'r');
|
|
// const buffer = Buffer.from(expected);
|
|
const bufferArr = allocateEmptyBuffers(exptectedBuff.length);
|
|
const expectedLength = exptectedBuff.length;
|
|
|
|
let { bytesRead, buffers } = await handle.readv([Buffer.from('')]);
|
|
assert.strictEqual(bytesRead, 0);
|
|
assert.deepStrictEqual(buffers, [Buffer.from('')]);
|
|
|
|
({ bytesRead, buffers } = await handle.readv(bufferArr));
|
|
assert.strictEqual(bytesRead, expectedLength);
|
|
assert.deepStrictEqual(buffers, bufferArr);
|
|
assert(Buffer.concat(bufferArr).equals(await fs.readFile(filename)));
|
|
handle.close();
|
|
}
|
|
})().then(common.mustCall());
|