e038d6a1cdThis completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
62 lines
1.7 KiB
JavaScript
62 lines
1.7 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-internals
|
|
|
|
// This test ensures that the type checking of ModuleMap throws
|
|
// errors appropriately
|
|
|
|
require('../common');
|
|
|
|
const assert = require('assert');
|
|
const { URL } = require('url');
|
|
const { Loader } = require('internal/modules/esm/loader');
|
|
const ModuleMap = require('internal/modules/esm/module_map');
|
|
const ModuleJob = require('internal/modules/esm/module_job');
|
|
const createDynamicModule = require(
|
|
'internal/modules/esm/create_dynamic_module');
|
|
|
|
const stubModuleUrl = new URL('file://tmp/test');
|
|
const stubModule = createDynamicModule(['default'], stubModuleUrl);
|
|
const loader = new Loader();
|
|
const moduleMap = new ModuleMap();
|
|
const moduleJob = new ModuleJob(loader, stubModule.module,
|
|
() => new Promise(() => {}));
|
|
|
|
assert.throws(
|
|
() => moduleMap.get(1),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "url" argument must be of type string. Received type number' +
|
|
' (1)'
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => moduleMap.set(1, moduleJob),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "url" argument must be of type string. Received type number' +
|
|
' (1)'
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => moduleMap.set('somestring', 'notamodulejob'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "job" argument must be an instance of ModuleJob. ' +
|
|
"Received type string ('notamodulejob')"
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => moduleMap.has(1),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "url" argument must be of type string. Received type number' +
|
|
' (1)'
|
|
}
|
|
);
|