node/test/pummel/test-keep-alive.js
Dylson Valente Neto cbc140fb6a
test: swap the order arguments are passed to assert
Documentation for assertions rule actual values should be passed first
followed by the expected value. This commit update the assertions the
changed file contains to comply to that rule. Changes also label the
assertions.

PR-URL: https://github.com/nodejs/node/pull/23580
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2018-10-17 11:29:53 -07:00

123 lines
3.4 KiB
JavaScript

// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict';
// This test requires the program 'wrk'
const common = require('../common');
if (common.isWindows)
common.skip('no `wrk` on windows');
const assert = require('assert');
const spawn = require('child_process').spawn;
const http = require('http');
const url = require('url');
const body = 'hello world\n';
const server = http.createServer(function(req, res) {
res.writeHead(200, {
'Content-Length': body.length,
'Content-Type': 'text/plain'
});
res.write(body);
res.end();
});
let keepAliveReqSec = 0;
let normalReqSec = 0;
function runAb(opts, callback) {
const args = [
'-c', opts.concurrent || 100,
'-t', opts.threads || 2,
'-d', opts.duration || '10s',
];
if (!opts.keepalive) {
args.push('-H');
args.push('Connection: close');
}
args.push(url.format({ hostname: '127.0.0.1',
port: common.PORT, protocol: 'http' }));
const child = spawn('wrk', args);
child.stderr.pipe(process.stderr);
child.stdout.setEncoding('utf8');
let stdout;
child.stdout.on('data', function(data) {
stdout += data;
});
child.on('close', function(code, signal) {
if (code) {
console.error(code, signal);
process.exit(code);
return;
}
let matches = /Requests\/sec:\s*(\d+)\./i.exec(stdout);
const reqSec = parseInt(matches[1]);
matches = /Keep-Alive requests:\s*(\d+)/i.exec(stdout);
let keepAliveRequests;
if (matches) {
keepAliveRequests = parseInt(matches[1]);
} else {
keepAliveRequests = 0;
}
callback(reqSec, keepAliveRequests);
});
}
server.listen(common.PORT, () => {
runAb({ keepalive: true }, (reqSec) => {
keepAliveReqSec = reqSec;
runAb({ keepalive: false }, function(reqSec) {
normalReqSec = reqSec;
server.close();
});
});
});
process.on('exit', function() {
assert.strictEqual(
normalReqSec > 50,
true,
`normalReqSec should be greater than 50, but got ${normalReqSec}`
);
assert.strictEqual(
keepAliveReqSec > 50,
true,
`keepAliveReqSec should be greater than 50, but got ${keepAliveReqSec}`
);
assert.strictEqual(
normalReqSec < keepAliveReqSec,
true,
'normalReqSec should be less than keepAliveReqSec, ' +
`but ${normalReqSec} is greater than ${keepAliveReqSec}`
);
});