b8ca616baaCurrently there are two compiler warnings generated from the addons test
callback-scope:
../binding.cc:44:10:
warning: 'Resolve' is deprecated [-Wdeprecated-declarations]
local->Resolve(v8::Undefined(isolate));
^
../../../../deps/v8/include/v8.h:3893:45:
note: 'Resolve' has been explicitly marked deprecated here
V8_DEPRECATED("Use maybe version", void Resolve(Local<Value> value));
^
../binding.cc:52:54:
warning: 'New' is deprecated [-Wdeprecated-declarations]
persistent.Reset(isolate, v8::Promise::Resolver::New(isolate));
^
../../../../deps/v8/include/v8.h:3880:42:
note: 'New' has been explicitly marked deprecated here
Local<Resolver> New(Isolate* isolate));
This commit updates the test to use non-deprecated functions.
PR-URL: https://github.com/nodejs/node/pull/19252
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
||
|---|---|---|
| .. | ||
| binding.cc | ||
| binding.gyp | ||
| test-async-hooks.js | ||
| test-resolve-async.js | ||
| test.js | ||