f44969a5ab
We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
66 lines
1.8 KiB
JavaScript
66 lines
1.8 KiB
JavaScript
/**
|
|
* @fileoverview Rule to enforce description with the `Symbol` object
|
|
* @author Jarek Rencz
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("../ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "require symbol descriptions",
|
|
category: "ECMAScript 6",
|
|
recommended: false
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
|
|
/**
|
|
* Reports if node does not conform the rule in case rule is set to
|
|
* report missing description
|
|
*
|
|
* @param {ASTNode} node - A CallExpression node to check.
|
|
* @returns {void}
|
|
*/
|
|
function checkArgument(node) {
|
|
if (node.arguments.length === 0) {
|
|
context.report({
|
|
node,
|
|
message: "Expected Symbol to have a description."
|
|
});
|
|
}
|
|
}
|
|
|
|
return {
|
|
"Program:exit"() {
|
|
const scope = context.getScope();
|
|
const variable = astUtils.getVariableByName(scope, "Symbol");
|
|
|
|
if (variable && variable.defs.length === 0) {
|
|
variable.references.forEach(reference => {
|
|
const node = reference.identifier;
|
|
|
|
if (astUtils.isCallee(node)) {
|
|
checkArgument(node.parent);
|
|
}
|
|
});
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|