We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
71 lines
1.9 KiB
JavaScript
71 lines
1.9 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag the generator functions that does not have yield.
|
|
* @author Toru Nagashima
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "require generator functions to contain `yield`",
|
|
category: "ECMAScript 6",
|
|
recommended: true
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
const stack = [];
|
|
|
|
/**
|
|
* If the node is a generator function, start counting `yield` keywords.
|
|
* @param {Node} node - A function node to check.
|
|
* @returns {void}
|
|
*/
|
|
function beginChecking(node) {
|
|
if (node.generator) {
|
|
stack.push(0);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* If the node is a generator function, end counting `yield` keywords, then
|
|
* reports result.
|
|
* @param {Node} node - A function node to check.
|
|
* @returns {void}
|
|
*/
|
|
function endChecking(node) {
|
|
if (!node.generator) {
|
|
return;
|
|
}
|
|
|
|
const countYield = stack.pop();
|
|
|
|
if (countYield === 0 && node.body.body.length > 0) {
|
|
context.report({ node, message: "This generator function does not have 'yield'." });
|
|
}
|
|
}
|
|
|
|
return {
|
|
FunctionDeclaration: beginChecking,
|
|
"FunctionDeclaration:exit": endChecking,
|
|
FunctionExpression: beginChecking,
|
|
"FunctionExpression:exit": endChecking,
|
|
|
|
// Increases the count of `yield` keyword.
|
|
YieldExpression() {
|
|
|
|
/* istanbul ignore else */
|
|
if (stack.length > 0) {
|
|
stack[stack.length - 1] += 1;
|
|
}
|
|
}
|
|
};
|
|
}
|
|
};
|