f44969a5ab
We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
71 lines
2.1 KiB
JavaScript
71 lines
2.1 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag references to undeclared variables.
|
|
* @author Mark Macdonald
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Checks if the given node is the argument of a typeof operator.
|
|
* @param {ASTNode} node The AST node being checked.
|
|
* @returns {boolean} Whether or not the node is the argument of a typeof operator.
|
|
*/
|
|
function hasTypeOfOperator(node) {
|
|
const parent = node.parent;
|
|
|
|
return parent.type === "UnaryExpression" && parent.operator === "typeof";
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow the use of undeclared variables unless mentioned in `/*global */` comments",
|
|
category: "Variables",
|
|
recommended: true
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
typeof: {
|
|
type: "boolean"
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
]
|
|
},
|
|
|
|
create(context) {
|
|
const options = context.options[0];
|
|
const considerTypeOf = options && options.typeof === true || false;
|
|
|
|
return {
|
|
"Program:exit"(/* node */) {
|
|
const globalScope = context.getScope();
|
|
|
|
globalScope.through.forEach(ref => {
|
|
const identifier = ref.identifier;
|
|
|
|
if (!considerTypeOf && hasTypeOfOperator(identifier)) {
|
|
return;
|
|
}
|
|
|
|
context.report({
|
|
node: identifier,
|
|
message: "'{{name}}' is not defined.",
|
|
data: identifier
|
|
});
|
|
});
|
|
}
|
|
};
|
|
}
|
|
};
|