f44969a5ab
We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
49 lines
1.3 KiB
JavaScript
49 lines
1.3 KiB
JavaScript
/**
|
|
* @fileoverview Disallow string concatenation when using __dirname and __filename
|
|
* @author Nicholas C. Zakas
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow string concatenation with `__dirname` and `__filename`",
|
|
category: "Node.js and CommonJS",
|
|
recommended: false
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const MATCHER = /^__(?:dir|file)name$/;
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
|
|
BinaryExpression(node) {
|
|
|
|
const left = node.left,
|
|
right = node.right;
|
|
|
|
if (node.operator === "+" &&
|
|
((left.type === "Identifier" && MATCHER.test(left.name)) ||
|
|
(right.type === "Identifier" && MATCHER.test(right.name)))
|
|
) {
|
|
|
|
context.report({ node, message: "Use path.join() or path.resolve() instead of + to create paths." });
|
|
}
|
|
}
|
|
|
|
};
|
|
|
|
}
|
|
};
|