f44969a5ab
We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
37 lines
976 B
JavaScript
37 lines
976 B
JavaScript
/**
|
|
* @fileoverview Rule to flag when using constructor for wrapper objects
|
|
* @author Ilya Volodin
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow `new` operators with the `String`, `Number`, and `Boolean` objects",
|
|
category: "Best Practices",
|
|
recommended: false
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
|
|
return {
|
|
|
|
NewExpression(node) {
|
|
const wrapperObjects = ["String", "Number", "Boolean", "Math", "JSON"];
|
|
|
|
if (wrapperObjects.indexOf(node.callee.name) > -1) {
|
|
context.report({ node, message: "Do not use {{fn}} as a constructor.", data: { fn: node.callee.name } });
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|