We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
43 lines
1.2 KiB
JavaScript
43 lines
1.2 KiB
JavaScript
/**
|
|
* @fileoverview Rule to disallow use of the new operator with the `Symbol` object
|
|
* @author Alberto Rodríguez
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow `new` operators with the `Symbol` object",
|
|
category: "ECMAScript 6",
|
|
recommended: true
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
|
|
return {
|
|
"Program:exit"() {
|
|
const globalScope = context.getScope();
|
|
const variable = globalScope.set.get("Symbol");
|
|
|
|
if (variable && variable.defs.length === 0) {
|
|
variable.references.forEach(ref => {
|
|
const node = ref.identifier;
|
|
|
|
if (node.parent && node.parent.type === "NewExpression") {
|
|
context.report({ node, message: "`Symbol` cannot be called as a constructor." });
|
|
}
|
|
});
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|