We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: https://github.com/nodejs/node/pull/10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
55 lines
1.7 KiB
JavaScript
55 lines
1.7 KiB
JavaScript
/**
|
|
* @fileoverview Rule to check for implicit global variables and functions.
|
|
* @author Joshua Peek
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow variable and `function` declarations in the global scope",
|
|
category: "Best Practices",
|
|
recommended: false
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
return {
|
|
Program() {
|
|
const scope = context.getScope();
|
|
|
|
scope.variables.forEach(variable => {
|
|
if (variable.writeable) {
|
|
return;
|
|
}
|
|
|
|
variable.defs.forEach(def => {
|
|
if (def.type === "FunctionName" || (def.type === "Variable" && def.parent.kind === "var")) {
|
|
context.report({ node: def.node, message: "Implicit global variable, assign as global property instead." });
|
|
}
|
|
});
|
|
});
|
|
|
|
scope.implicit.variables.forEach(variable => {
|
|
const scopeVariable = scope.set.get(variable.name);
|
|
|
|
if (scopeVariable && scopeVariable.writeable) {
|
|
return;
|
|
}
|
|
|
|
variable.defs.forEach(def => {
|
|
context.report({ node: def.node, message: "Implicit global variable, assign as global property instead." });
|
|
});
|
|
});
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|